Page MenuHomeFreeBSD

libgcc_s: restore __*_frame_info symbols post llvm18
ClosedPublic

Authored by brooks on Apr 19 2024, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 12:01 AM
Unknown Object (File)
Wed, Nov 20, 5:31 PM
Unknown Object (File)
Wed, Nov 20, 3:29 PM
Unknown Object (File)
Nov 13 2024, 11:27 PM
Unknown Object (File)
Nov 12 2024, 9:45 AM
Unknown Object (File)
Nov 7 2024, 5:01 PM
Unknown Object (File)
Nov 6 2024, 1:20 AM
Unknown Object (File)
Oct 18 2024, 9:25 AM
Subscribers

Details

Summary

The upstream llvm commit 5eb44df1b64d made the addition of these GCC
compatability symbols dependent on build configuration rather than
hardcoded for amd64, i386, and powerpc. Reenable them.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Otherwise, LGTM.

lib/libgcc_eh/Makefile.inc
20

I'm always a bit confused by these unquoted strings... But apparently make groks this? :)

This revision is now accepted and ready to land.Apr 19 2024, 9:35 PM
lib/libgcc_eh/Makefile.inc
20

I can quote them if you prefer

lib/libgcc_eh/Makefile.inc
20

I can quote them if you prefer

Please do, other string values are also quoted in this same file.