Page MenuHomeFreeBSD

msun/riscv: limit exposure of fegetexcept
AbandonedPublic

Authored by brooks on Mar 12 2024, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 3:00 PM
Unknown Object (File)
Thu, Nov 21, 8:15 AM
Unknown Object (File)
Mon, Nov 18, 11:48 PM
Unknown Object (File)
Mon, Nov 18, 3:50 PM
Unknown Object (File)
Mon, Nov 18, 1:28 PM
Unknown Object (File)
Mon, Nov 18, 3:53 AM
Unknown Object (File)
Fri, Nov 15, 11:24 PM
Unknown Object (File)
Tue, Nov 12, 10:38 AM
Subscribers

Details

Reviewers
emaste
jrtc27
Group Reviewers
riscv
Summary

fegetexcept is a static inline function in the default hardfloat
ABI so only expose it the softfloat case.

Given we've removed riscv64sf from the tree we might want to GC this
entierly at some point.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56569
Build 53457: arc lint + arc unit

Event Timeline

Oh I had it as an in-progress patch to make these *not* inline-only. I don't think it's a bug that they're only inline, but every other architecture exposes them as actual symbols too and GCC at least relies on that. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272759 (comment 5 in particular) and https://cgit.freebsd.org/src/commit/?id=448c505c33cc334193590f3844406d6a74f26e2a.

Oh I had it as an in-progress patch to make these *not* inline-only. I don't think it's a bug that they're only inline, but every other architecture exposes them as actual symbols too and GCC at least relies on that. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272759 (comment 5 in particular) and https://cgit.freebsd.org/src/commit/?id=448c505c33cc334193590f3844406d6a74f26e2a.

Ah, I'll grab that and apply it.

Oh I had it as an in-progress patch to make these *not* inline-only. I don't think it's a bug that they're only inline, but every other architecture exposes them as actual symbols too and GCC at least relies on that. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272759 (comment 5 in particular) and https://cgit.freebsd.org/src/commit/?id=448c505c33cc334193590f3844406d6a74f26e2a.

Ah, I'll grab that and apply it.

Apparently, and not surprisingly, my completely-untested patch wasn't quite right, but whatever I missed is probably straightforward to fix.

brooks retitled this revision from lib/msun: limit exposure of riscv softfloat symbols to msun/riscv: limit exposure of fegetexcept.Mar 12 2024, 10:48 PM
brooks edited the summary of this revision. (Show Details)

Reduce scope to fegetexcept

I'd just skip to removing outright I think.

OK but I agree with jhb that skipping ahead to removal is fine

This revision is now accepted and ready to land.Mar 19 2024, 5:13 PM