Page MenuHomeFreeBSD

libc/iconv: don't export nonexistant symbols
ClosedPublic

Authored by brooks on Mar 1 2024, 11:55 PM.
Tags
None
Referenced Files
F86671061: D44183.id135299.diff
Sun, Jun 23, 6:57 PM
Unknown Object (File)
Mon, Jun 17, 9:22 AM
Unknown Object (File)
Mon, Jun 17, 9:21 AM
Unknown Object (File)
Mon, Jun 17, 9:21 AM
Unknown Object (File)
Mon, Jun 17, 8:31 AM
Unknown Object (File)
Sun, Jun 16, 7:06 AM
Unknown Object (File)
Tue, May 28, 7:55 PM
Unknown Object (File)
Sun, May 26, 3:08 PM
Subscribers

Details

Summary

It's unclear to me that any of these symbols ever existed. The ones
I've spot checked are only mentioned in the initial Citrus iconv import
(commit ad30f8e79bd1) and this code hasn't changed much over time.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56392
Build 53280: arc lint + arc unit

Event Timeline

lib/libc/iconv/Symbol.map
40

At least this one...

62

... and this set, or so, should be used by various lib/libiconv_modules through a lot of macro shenanigans ("indirection")... do you still end up with a functional libiconv?

ah, I see; some of these were inlined in a header, some of them left un-exported in the first place... someone seemingly applied a relatively large hammer.

This revision is now accepted and ready to land.Mar 7 2024, 2:39 AM
This revision was automatically updated to reflect the committed changes.