Page MenuHomeFreeBSD

Make WITHOUT_UNDEFINED_VERSION the default
ClosedPublic

Authored by brooks on Mar 5 2024, 1:07 AM.
Tags
None
Referenced Files
F104272519: D44216.diff
Thu, Dec 5, 4:35 PM
Unknown Object (File)
Sun, Dec 1, 9:53 PM
Unknown Object (File)
Sat, Nov 30, 10:30 AM
Unknown Object (File)
Mon, Nov 25, 7:56 AM
Unknown Object (File)
Sun, Nov 24, 7:25 PM
Unknown Object (File)
Sun, Nov 24, 4:31 PM
Unknown Object (File)
Sat, Nov 23, 4:04 PM
Unknown Object (File)
Thu, Nov 21, 7:28 PM

Details

Summary

Link with --no-undefined-version by default. Will detect and prevent
the accidental removal of symbols from versioned libraries.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Mar 5 2024, 1:07 AM

This is successful everywhere (i.e. architectures, discounting conflicts with other options that Michael Dexter's option survey will find)?

This isn't ready to land, but adding it to give me somewhere to hang all the otherwise unrelated reviews I'll post over the next day or so (I've got amd64 and i386 working so far).

With D45052 committed, this passes a make CROSS_TOOLCHAIN=llvm18 -DWITHOUT_TOOLCHAIN -DMAKE_JUST_WORLDS -j40 tinderbox run. I'll kick off a full run over night in case there are issues in the toolchain bits, but I think this is ready to land. We have had several regressions since I first posted this review so getting this in is clearly valuable (admittedly, a number of which were my fault in merging patches I failed to notice had gotten out of date.)

This revision is now accepted and ready to land.May 1 2024, 10:33 PM
This revision was automatically updated to reflect the committed changes.