tcp: limit namespace for tcp_[gs]et_flags
ClosedPublic
Actions

There is another namespace issue in tcp.h. There have been several additions near the end of the file, after the #endif at line 458. The #endif closes the #ifdef _BSD_VISIBLE at line 181. The #endif should be moved to line 544, just before the closing #endif, as the additions are not in POSIX, and the #endif should be commented as /* _BSD_VISIBLE */ so people are less likely to add things after it. If you don't want to combine the namespace fixes, I can do it later.

kib added inline comments.Dec 30 2023, 5:54 PM

sys/netinet/tcp.h
96	I.e. using function-like macro is more to the point there, at least checking the number of args for substitution.

Address comments made by kib and karels.

In D43245#985642, @karels wrote:

There is another namespace issue in tcp.h. There have been several additions near the end of the file, after the #endif at line 458. The #endif closes the #ifdef _BSD_VISIBLE at line 181. The #endif should be moved to line 544, just before the closing #endif, as the additions are not in POSIX, and the #endif should be commented as /* _BSD_VISIBLE */ so people are less likely to add things after it. If you don't want to combine the namespace fixes, I can do it later.

Done in the latest diff.

sys/netinet/tcp.h
96	Done in the latest diff.

tuexen marked an inline comment as done.Dec 31 2023, 10:47 AM

Q: Are Userspace Applications then supposed use the __tcp_[gs]et_flags directly, or #define their tcp_[gs]et_flags locally?

In D43245#985818, @rscheff wrote:

Q: Are Userspace Applications then supposed use the __tcp_[gs]et_flags directly, or #define their tcp_[gs]et_flags locally?

It is up to the app itself, we cannot mandate it. In both cases the code uses __tcp_set_flags(), further style issues are outside the scope of the OS compilation environment.