Page MenuHomeFreeBSD
Differential D40148

linux(4): Add a dedicated linux_exec_copyin_args()
ClosedPublic
Actions

Authored by dchagin on May 18 2023, 6:42 PM.
Tags
None
Referenced Files
F167379765: D40148.id.diff
Fri, Aug 21, 11:28 AM
Unknown Object (File)
Tue, Aug 18, 8:06 AM
Unknown Object (File)
Tue, Aug 11, 8:19 PM
Unknown Object (File)
Tue, Aug 11, 3:47 PM
Unknown Object (File)
Sun, Aug 9, 3:09 PM
Unknown Object (File)
Sun, Aug 9, 10:28 AM
Unknown Object (File)
Fri, Aug 7, 10:39 PM
Unknown Object (File)
Fri, Aug 7, 5:31 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
brooks
Commits
rG8340b03425cf: linux(4): Add a dedicated linux_exec_copyin_args()
Summary

Because Linux allows to exec binaries with 0 argc.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51538
Build 48429: arc lint + arc unit

Event Timeline

dchagin created this revision.May 18 2023, 6:42 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 18 2023, 6:42 PM
Herald added a reviewer: brooks. · View Herald Transcript
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
dchagin requested review of this revision.May 18 2023, 6:42 PM
Harbormaster completed remote builds in B51538: Diff 122084.May 18 2023, 6:42 PM
emaste added a comment.EditedMay 18 2023, 7:33 PM

Are we aware of any actual Linux binary use cases for argc=0? (I don't object to this change, just wondering.)

brooks accepted this revision.May 18 2023, 7:41 PM
This revision is now accepted and ready to land.May 18 2023, 7:41 PM
dchagin added a comment.May 18 2023, 8:46 PM
In D40148#914234, @emaste wrote:

Are we aware of any actual Linux binary use cases for argc=0? (I don't object to this change, just wondering.)

well, I dont know, I’m not use Linux since 1997:)
I try to fix Glibc posix_spawn(), for which some glibc tests fails due to argc=0, also see comment in the linux_exec_copyin_args() explaining this change

Closed by commit rG8340b03425cf: linux(4): Add a dedicated linux_exec_copyin_args() (authored by dchagin). · Explain WhyMay 29 2023, 9:19 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG8340b03425cf: linux(4): Add a dedicated linux_exec_copyin_args().

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
4 lines
linux32/
14 lines
4 lines
arm64/
linux/
4 lines
compat/
linux/
87 lines
i386/
linux/
4 lines

Diff 122084

View Options

sys/amd64/linux/syscalls.master

Loading...
View Options

sys/amd64/linux32/linux32_machdep.c

Loading...
View Options

sys/amd64/linux32/syscalls.master

Loading...
View Options

sys/arm64/linux/syscalls.master

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/i386/linux/syscalls.master

Loading...