Page MenuHomeFreeBSD
Differential D38601

inpcb: use family specific sockaddr argument for bind functions
ClosedPublic
Actions

Authored by glebius on Feb 15 2023, 2:40 AM.
Tags
None
Referenced Files
F149808640: D38601.diff
Fri, Mar 27, 6:31 AM
Unknown Object (File)
Thu, Mar 19, 3:59 PM
Unknown Object (File)
Wed, Mar 18, 11:07 PM
Unknown Object (File)
Mon, Mar 16, 1:43 AM
Unknown Object (File)
Sun, Mar 15, 7:41 PM
Unknown Object (File)
Mon, Mar 2, 2:28 PM
Unknown Object (File)
Mon, Mar 2, 12:36 PM
Unknown Object (File)
Mon, Mar 2, 6:52 AM
View All Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
markj
zlei
melifaro
Group Reviewers
network
transport
Commits
rG96871af01382: inpcb: use family specific sockaddr argument for bind functions
Summary

Do the cast from sockaddr to either IPv4 or IPv6 sockaddr in the
protocol's pr_bind method and from there on go down the call
stack with family specific argument.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Feb 15 2023, 2:40 AM
Herald added a reviewer: transport. · View Herald TranscriptFeb 15 2023, 2:40 AM
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
glebius requested review of this revision.Feb 15 2023, 2:40 AM
Harbormaster completed remote builds in B49793: Diff 117275.Feb 15 2023, 2:40 AM
zlei accepted this revision.Feb 15 2023, 4:51 AM
zlei added a subscriber: zlei.

Looks good to me.

melifaro accepted this revision as: melifaro.Feb 15 2023, 9:45 AM

Finally, we're getting rid of nam. Nice!

markj accepted this revision.Feb 15 2023, 2:37 PM
markj added inline comments.
sys/netinet/in_pcb.c
904

BTW, we are not consistent about using struct in_addr vs. struct in_addr * vs. in_addr_t in inpcb interfaces. It would be nice to simplify that too.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2023, 6:31 PM
Closed by commit rG96871af01382: inpcb: use family specific sockaddr argument for bind functions (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG96871af01382: inpcb: use family specific sockaddr argument for bind functions.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
22 lines
7 lines
6 lines
netinet6/
2 lines
7 lines
12 lines

Diff 117313

View Options

sys/netinet/in_pcb.h

Loading...
View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...
View Options

sys/netinet/udp_usrreq.c

Loading...
View Options

sys/netinet6/in6_pcb.h

Loading...
View Options

sys/netinet6/in6_pcb.c

Loading...
View Options

sys/netinet6/udp6_usrreq.c

Loading...