Differential D37062

tcp: inp_socket is valid through the lifetime of a TCP inpcb
ClosedPublic
Actions

Authored by glebius on Oct 19 2022, 10:43 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rGf71cb9f74808: tcp: inp_socket is valid through the lifetime of a TCP inpcb

Summary

The inp_socket is cleared only in in_pcbdetach(), which for TCP is
always accompanied with inp_pcbfree(). An inpcb that went through
in_pcbfree() shall never be returned by any kind of pcb lookup.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Oct 19 2022, 10:43 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptOct 19 2022, 10:43 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Oct 19 2022, 10:43 PM

Harbormaster completed remote builds in B47923: Diff 112013.Oct 19 2022, 10:44 PM

glebius added a parent revision: D37061: inpcb: don't return INP_DROPPED entries from pcb lookups.Oct 19 2022, 10:51 PM

tuexen accepted this revision.Oct 20 2022, 9:28 AM

This revision is now accepted and ready to land.Oct 20 2022, 9:28 AM

glebius added a child revision: D37123: tcp: provide macros to access inpcb and socket from a tcpcb.Oct 25 2022, 6:20 PM

glebius added a child revision: D37127: tcp: embed inpcb into tcpcb.Oct 25 2022, 7:01 PM

Closed by commit rGf71cb9f74808: tcp: inp_socket is valid through the lifetime of a TCP inpcb (authored by glebius). · Explain WhyNov 8 2022, 6:26 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGf71cb9f74808: tcp: inp_socket is valid through the lifetime of a TCP inpcb.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

2 lines

tcp_subr.c

177 lines

tcp_timer.c

2 lines

Diff 112785

View Options

sys/netinet/tcp_input.c

View Options

sys/netinet/tcp_subr.c

View Options

tcp: inp_socket is valid through the lifetime of a TCP inpcbClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 112785

sys/netinet/tcp_input.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_timer.c

tcp: inp_socket is valid through the lifetime of a TCP inpcb
ClosedPublic
Actions

Revision Contents
Changeset List