Paths

Table of Contentst

Differential D37150

vmm: Rework snapshotting of CPU-specific per-vCPU data.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 12:13 PM

	Unknown Object (File)
	Sun, Feb 8, 5:33 AM

	Unknown Object (File)
	Sun, Feb 8, 4:22 AM

	Unknown Object (File)
	Mon, Feb 2, 9:45 AM

	Unknown Object (File)
	Mon, Feb 2, 4:52 AM

	Unknown Object (File)
	Sun, Feb 1, 8:36 AM

	Unknown Object (File)
	Sat, Jan 31, 1:24 AM

	Unknown Object (File)
	Fri, Jan 16, 6:15 AM

Subscribers

Details

Reviewers

markj
corvink
manu

Group Reviewers

Commits

rGf5bc0f746681: vmm: Rework snapshotting of CPU-specific per-vCPU data.
rG39ec056e6dbd: vmm: Rework snapshotting of CPU-specific per-vCPU data.

Summary

Previously some per-vCPU state was saved in vmmops_snapshot and other
state was saved in vmmops_vcmx_snapshot. Consolidate all per-vCPU
state into the latter routine and rename the hook to the more generic
'vcpu_snapshot'. Note that the CPU-independent per-vCPU data is still
stored in a separate blob as well as the per-vCPU local APIC data.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48137
Build 45024: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 27 2022, 3:03 PM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:03 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Oct 27 2022, 3:03 PM

jhb added a parent revision: D37149: vmm vmx: Refactor per-vCPU data..

jhb added a child revision: D37151: vmm: Refactor storage of CPU-dependent per-vCPU data..

Harbormaster completed remote builds in B48022: Diff 112259.Oct 27 2022, 3:03 PM

markj accepted this revision as: markj.Nov 2 2022, 2:43 PM

markj added inline comments.

sys/amd64/vmm/amd/svm.c
2595	"i" is gone.
2640	Elsewhere this is done with `svm_set_dirty(svm_sc, vcpu, 0xffffffff);`. This code is missing VMCB_CACHE_LBR.

This revision is now accepted and ready to land.Nov 2 2022, 2:43 PM

jhb added inline comments.Nov 3 2022, 10:40 PM

sys/amd64/vmm/amd/svm.c
2640	I might fix that in a separate commit I'll add to the series. This is just a copy/paste of the old code.

jhb added a parent revision: D37259: vmm svm: Mark all VMCB state caches dirty on vCPU restore..Nov 3 2022, 11:43 PM

jhb removed a parent revision: D37149: vmm vmx: Refactor per-vCPU data..

jhb updated this revision to Diff 112577.Nov 3 2022, 11:48 PM

This revision now requires review to proceed.Nov 3 2022, 11:48 PM

Harbormaster completed remote builds in B48137: Diff 112577.Nov 3 2022, 11:48 PM

corvink accepted this revision.Nov 4 2022, 7:20 AM

corvink added a reviewer: manu.

This revision is now accepted and ready to land.Nov 4 2022, 7:20 AM

jhb added a child revision: D37269: vmm vmx: Add a global bool to indicate if the host has the TSC_AUX MSR..Nov 4 2022, 6:07 PM

jhb removed a child revision: D37151: vmm: Refactor storage of CPU-dependent per-vCPU data..

markj accepted this revision as: markj.Nov 4 2022, 11:06 PM

Closed by commit rG39ec056e6dbd: vmm: Rework snapshotting of CPU-specific per-vCPU data. (authored by jhb). · Explain WhyNov 18 2022, 6:27 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG39ec056e6dbd: vmm: Rework snapshotting of CPU-specific per-vCPU data..

jhb added a commit: rGf5bc0f746681: vmm: Rework snapshotting of CPU-specific per-vCPU data..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

4 lines

vmm/

amd/

239 lines

intel/

87 lines

4 lines

Diff 112577

sys/amd64/include/vmm.h

Loading...

sys/amd64/vmm/amd/svm.c

Loading...

sys/amd64/vmm/intel/vmx.c

Loading...

sys/amd64/vmm/vmm.c

Loading...