Page MenuHomeFreeBSD
Differential D36309

Allow to specify umask(1) for a service started with rc(8)
ClosedPublic
Actions

Authored by eugen_grosbein.net on Aug 23 2022, 12:07 PM.
Tags
Referenced Files
F103758031: D36309.diff
Fri, Nov 29, 1:02 AM
Unknown Object (File)
Thu, Nov 21, 5:38 PM
Unknown Object (File)
Mon, Nov 18, 11:45 PM
Unknown Object (File)
Thu, Nov 14, 1:50 AM
Unknown Object (File)
Tue, Nov 12, 3:41 PM
Unknown Object (File)
Oct 19 2024, 2:55 AM
Unknown Object (File)
Oct 13 2024, 11:52 AM
Unknown Object (File)
Oct 9 2024, 9:34 AM
View All 79 Files
Subscribers
andrew_tao173.riddles.org.uk
emaste
imp
pauamma_gundo.com

Details

Reviewers
franco_opnsense.org
0mp
mike.walker_napkindrawing.com
jlduran
mhorne
sobomax
oshogbo
crees
kevans
pauamma_gundo.com
Group Reviewers
manpages
Commits
rG160a2f2cdda8: rc.conf(5): add <service>_umask to run the service using this value
Summary

Currently we have multiple ways to modify environment (variables, working directory, limits etc.) for a service without touching its startup script but no way to change default umask(1) value. None of tools working with login classes change umask.

Also, we have no ways to extract umask by class name for shell script. Let us deal with the problem in simple way via new servicename_umask knob for rc.conf(5)

Some file-sharing services that create new files may benefit from it.

Test Plan

N/A

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47076

Event Timeline

eugen_grosbein.net created this revision.Aug 23 2022, 12:07 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 23 2022, 12:07 PM
Herald added a subscriber: imp. · View Herald Transcript
eugen_grosbein.net requested review of this revision.Aug 23 2022, 12:07 PM
Harbormaster completed remote builds in B47076: Diff 109711.Aug 23 2022, 12:07 PM
eugen_grosbein.net updated this revision to Diff 109716.Aug 23 2022, 12:33 PM

Add missing chunk.

Harbormaster completed remote builds in B47078: Diff 109716.Aug 23 2022, 12:33 PM
pauamma_gundo.com accepted this revision.Aug 25 2022, 10:03 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Manual page change LGTM and seems consistent with what I think the intent of the rc.subr change is. Can't vouch for the implementation.

This revision is now accepted and ready to land.Aug 25 2022, 10:03 PM
eugen_grosbein.net added a comment.Aug 26 2022, 2:43 AM
In D36309#825545, @pauamma wrote:

Manual page change LGTM and seems consistent with what I think the intent of the rc.subr change is. Can't vouch for the implementation.

Thanks.

I'm going to commit this soon unless an objection raised.

eugen_grosbein.net mentioned this in rG160a2f2cdda8: rc.conf(5): add <service>_umask to run the service using this value.Aug 28 2022, 5:49 AM
0mp added a project: rc.Nov 17 2022, 8:04 PM
jlduran added a comment.Jul 19 2023, 4:45 PM

Is there a reason why this change was not MFCd? Thank you!

Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJul 19 2023, 4:45 PM
eugen_grosbein.net mentioned this in rG2d6a03dd43c7: rc.conf(5): add <service>_umask to run the service using this value.Dec 2 2023, 8:16 AM
eugen_grosbein.net mentioned this in rG2e6541b943ef: rc.conf(5): add <service>_umask to run the service using this value.Dec 2 2023, 8:44 AM
eugen_grosbein.net added a comment.Dec 2 2023, 9:20 AM
In D36309#935684, @jlduran_gmail.com wrote:

Is there a reason why this change was not MFCd? Thank you!

Forgot about it. I've just merged it downto stable/12.

jlduran added a comment.EditedDec 2 2023, 12:41 PM
In D36309#977969, @eugen_grosbein.net wrote:
In D36309#935684, @jlduran_gmail.com wrote:

Is there a reason why this change was not MFCd? Thank you!

Forgot about it. I've just merged it downto stable/12.

Thank you! /etc/rc.d/dmesg might just be its first consumer!

emaste closed this revision.May 6 2024, 5:04 PM
emaste added a commit: rG160a2f2cdda8: rc.conf(5): add <service>_umask to run the service using this value.
emaste added a subscriber: emaste.

Was committed (tag was Differential not Differential Revision so it did not auto-close).

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.subr
rc.subr.orig
7 lines
share/
man/
man5/
rc.conf.5
rc.conf.5.orig
8 lines

Diff 109711

View Options

libexec/rc/rc.subr

Loading...
View Options

share/man/man5/rc.conf.5

Loading...