Page MenuHomeFreeBSD
Differential D36161

mld6: use callout(9) directly instead of pr_slowtimo, pr_fasttimo
ClosedPublic
Actions

Authored by glebius on Aug 12 2022, 8:15 AM.
Tags
None
Referenced Files
F122272134: D36161.id109227.diff
Thu, Jul 3, 10:37 PM
Unknown Object (File)
Tue, Jul 1, 5:45 PM
Unknown Object (File)
Tue, Jul 1, 5:43 PM
Unknown Object (File)
Mon, Jun 30, 7:38 PM
Unknown Object (File)
Sun, Jun 29, 12:00 AM
Unknown Object (File)
Sat, Jun 28, 10:45 PM
Unknown Object (File)
Sat, Jun 28, 12:59 PM
Unknown Object (File)
Fri, Jun 27, 12:43 AM
View All Files
Subscribers
ae
bz
imp
melifaro

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rGb730de8badbc: mld6: use callout(9) directly instead of pr_slowtimo, pr_fasttimo

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46889
Build 43778: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 12 2022, 8:15 AM
Herald added subscribers: melifaro, bz, ae, imp. · View Herald TranscriptAug 12 2022, 8:15 AM
glebius requested review of this revision.Aug 12 2022, 8:15 AM
glebius added a parent revision: D36160: igmp: use callout(9) directly instead of pr_slowtimo, pr_fasttimo.
Harbormaster completed remote builds in B46885: Diff 109227.Aug 12 2022, 8:15 AM
glebius added a child revision: D36162: frag6: use callout(9) directly instead of pr_slowtimo.Aug 12 2022, 8:15 AM
glebius updated this revision to Diff 109231.Aug 12 2022, 8:20 AM

Rebase - part belonged to other diff.

Harbormaster completed remote builds in B46889: Diff 109231.Aug 12 2022, 8:20 AM
melifaro accepted this revision.Aug 12 2022, 11:08 AM
This revision is now accepted and ready to land.Aug 12 2022, 11:08 AM
melifaro added inline comments.Aug 12 2022, 11:21 AM
sys/netinet6/mld6.c
1726

Probably worth using callout_reset_sbt() to indicate absolute timeout.

melifaro added inline comments.Aug 12 2022, 11:27 AM
sys/netinet6/mld6.c
1298

We need to enter epoch here.

mld_fasttimo_vnet() calls mld_v2_dispatch_general_query() which requires epoch to be present.

glebius added inline comments.Aug 12 2022, 3:08 PM
sys/netinet6/mld6.c
1298

Thanks! Will do.

1726

I'd better leave functional improvements for future, not in this changeset.

glebius updated this revision to Diff 109249.Aug 12 2022, 3:28 PM

Fix epoch issues.

This revision now requires review to proceed.Aug 12 2022, 3:28 PM
Harbormaster completed remote builds in B46901: Diff 109249.Aug 12 2022, 3:28 PM
melifaro accepted this revision.Aug 17 2022, 4:00 PM
This revision is now accepted and ready to land.Aug 17 2022, 4:00 PM
glebius updated this revision to Diff 109471.Aug 17 2022, 5:00 PM

Rename PR_FOOHZ to MLD_FOOHZ

This revision now requires review to proceed.Aug 17 2022, 5:00 PM
Harbormaster completed remote builds in B47002: Diff 109471.Aug 17 2022, 5:00 PM
melifaro accepted this revision.Aug 17 2022, 6:09 PM
This revision is now accepted and ready to land.Aug 17 2022, 6:09 PM
Closed by commit rGb730de8badbc: mld6: use callout(9) directly instead of pr_slowtimo, pr_fasttimo (authored by glebius). · Explain WhyAug 17 2022, 6:54 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGb730de8badbc: mld6: use callout(9) directly instead of pr_slowtimo, pr_fasttimo.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines
netinet6/
14 lines
1 line
2 lines
22 lines
5 lines

Diff 109231

View Options

sys/netinet/icmp6.h

Loading...
View Options

sys/netinet6/icmp6.c

Loading...
View Options

sys/netinet6/in6.c

Loading...
View Options

sys/netinet6/in6_proto.c

Loading...
View Options

sys/netinet6/mld6.c

Loading...
View Options

sys/netinet6/mld6_var.h

Loading...