Details

Reviewers

tuexen
melifaro

Group Reviewers

network
transport

Commits

rG6c452841ef9b: tcp: use callout(9) directly instead of pr_slowtimo

Summary

Modern TCP stacks uses multiple callouts per tcpcb, and a global
callout is ancient artifact. However it is still used to garbage
collect compressed timewait entries.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 12 2022, 8:14 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 12 2022, 8:14 AM

Herald added subscribers: melifaro, bz, ae, imp. · View Herald Transcript

glebius requested review of this revision.Aug 12 2022, 8:14 AM

Harbormaster completed remote builds in B46883: Diff 109225.Aug 12 2022, 8:14 AM

glebius added a parent revision: D36158: protosw: just use NULL pointer instead of struct nousrreqs.Aug 12 2022, 8:14 AM

glebius added a child revision: D36160: igmp: use callout(9) directly instead of pr_slowtimo, pr_fasttimo.

tuexen accepted this revision as: transport, tuexen.Aug 12 2022, 10:06 AM

This revision is now accepted and ready to land.Aug 12 2022, 10:06 AM

melifaro accepted this revision.Aug 12 2022, 11:04 AM

melifaro added inline comments.Aug 12 2022, 11:16 AM

sys/netinet/tcp_subr.c
1573 ↗	(On Diff #109225)	Maybe schedule it immediately to avoid duplicating the timeout? Or define it explicitly in `tcp_var.h` ?
sys/netinet/tcp_timer.c
256