Page MenuHomeFreeBSD
Differential D36159

tcp: use callout(9) directly instead of pr_slowtimo
ClosedPublic
Actions

Authored by glebius on Aug 12 2022, 8:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 2, 12:51 PM
Unknown Object (File)
Sun, Jun 28, 5:16 AM
Unknown Object (File)
Fri, Jun 26, 6:14 PM
Unknown Object (File)
Mon, Jun 22, 4:07 PM
Unknown Object (File)
Mon, Jun 22, 3:21 PM
Unknown Object (File)
Mon, Jun 22, 10:34 AM
Unknown Object (File)
Thu, Jun 18, 10:39 PM
Unknown Object (File)
Tue, Jun 16, 12:56 PM
View All Files
Subscribers
ae
bz
imp
melifaro

Details

Reviewers
tuexen
melifaro
Group Reviewers
network
transport
Commits
rG6c452841ef9b: tcp: use callout(9) directly instead of pr_slowtimo
Summary

Modern TCP stacks uses multiple callouts per tcpcb, and a global
callout is ancient artifact. However it is still used to garbage
collect compressed timewait entries.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46883
Build 43772: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 12 2022, 8:14 AM
Herald added a reviewer: transport. · View Herald TranscriptAug 12 2022, 8:14 AM
Herald added subscribers: melifaro, bz, ae, imp. · View Herald Transcript
glebius requested review of this revision.Aug 12 2022, 8:14 AM
Harbormaster completed remote builds in B46883: Diff 109225.Aug 12 2022, 8:14 AM
glebius added a parent revision: D36158: protosw: just use NULL pointer instead of struct nousrreqs.Aug 12 2022, 8:14 AM
glebius added a child revision: D36160: igmp: use callout(9) directly instead of pr_slowtimo, pr_fasttimo.
tuexen accepted this revision as: transport, tuexen.Aug 12 2022, 10:06 AM
This revision is now accepted and ready to land.Aug 12 2022, 10:06 AM
melifaro accepted this revision.Aug 12 2022, 11:04 AM
melifaro added inline comments.Aug 12 2022, 11:16 AM
sys/netinet/tcp_subr.c
1573

Maybe schedule it immediately to avoid duplicating the timeout? Or define it explicitly in tcp_var.h ?

sys/netinet/tcp_timer.c
256
glebius updated this revision to Diff 109433.Aug 16 2022, 10:12 PM

Bugfix + rebase.

This revision now requires review to proceed.Aug 16 2022, 10:12 PM
Harbormaster completed remote builds in B46984: Diff 109433.Aug 16 2022, 10:12 PM
glebius updated this revision to Diff 109469.Aug 17 2022, 5:00 PM

Use callout_reset_sbt

Harbormaster completed remote builds in B47000: Diff 109469.Aug 17 2022, 5:00 PM
melifaro accepted this revision as: network, melifaro.Aug 17 2022, 6:07 PM
This revision is now accepted and ready to land.Aug 17 2022, 6:07 PM
Closed by commit rG6c452841ef9b: tcp: use callout(9) directly instead of pr_slowtimo (authored by glebius). · Explain WhyAug 17 2022, 6:54 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG6c452841ef9b: tcp: use callout(9) directly instead of pr_slowtimo.

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line
3 lines
13 lines
3 lines
netinet6/
1 line

Diff 109225

View Options

sys/netinet/in_proto.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_timer.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...
View Options

sys/netinet6/in6_proto.c

Loading...