Page MenuHomeFreeBSD
Differential D35437

Add SPLIT_KERNEL_DEBUG knob
ClosedPublic
Actions

Authored by emaste on Jun 8 2022, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 7:26 AM
Unknown Object (File)
Mar 23 2024, 4:26 AM
Unknown Object (File)
Mar 16 2024, 5:41 PM
Unknown Object (File)
Mar 16 2024, 5:41 PM
Unknown Object (File)
Mar 16 2024, 5:41 PM
Unknown Object (File)
Mar 16 2024, 5:41 PM
Unknown Object (File)
Mar 16 2024, 5:41 PM
Unknown Object (File)
Mar 14 2024, 1:47 AM
View All 32 Files
Subscribers
bdrewery
cem
markj

Details

Reviewers
imp
eugen_grosbein.net
Commits
rG0c4d13c521aa: Add SPLIT_KERNEL_DEBUG knob
rGe3709cfe6a2a: Add SPLIT_KERNEL_DEBUG knob
Summary

PR: 264433

This may not be fully complete (I have not investigated the kernel itself, only modules) but am posting for review of the knob/concept.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 8 2022, 5:25 PM
emaste updated this revision to Diff 106769.
emaste created this revision.

Full diff not just src.conf.5

emaste added subscribers: bdrewery, cem, markj.Jun 8 2022, 5:35 PM

I have not investigated the kernel itself

kernel build never changed, so does not need to be touched here.

CC @bdrewery as he added the setting of MK_KERNEL_SYMBOLS=no in ports 5968fb2d2ff5e. If this D35437 change is going to go in we'll want to set MK_SPLIT_KERNEL_DEBUG=no also.

share/man/man5/src.conf.5
654–656

This is due to conflicting FDT defaults and can be ignored
(this hunk will be manually reverted prior to pushing to main)

emaste added a comment.Jun 8 2022, 5:39 PM

Rather, ports 064127e4d8e2e was the original introduction of the functionality.

emaste updated this revision to Diff 106773.Jun 8 2022, 5:43 PM

Include WITHOUT_SPLIT_KERNEL_DEBUG description file in diff

eugen_grosbein.net accepted this revision.Jun 8 2022, 6:47 PM

I've applied the change to stable/13 manually fixing some rejection and tested it. Works like a charm, thank you. Please commit.

This revision is now accepted and ready to land.Jun 8 2022, 6:47 PM
eugen_grosbein.net added a comment.EditedJun 8 2022, 6:48 PM

To clarify: I ran make buildkernel && make installkernel having *no* MODULES_WITH_WORLD= in /etc/src.conf
and no DEBUG=

Works as expected matching 12.3 behaviour.

eugen_grosbein.net added a comment.Jun 8 2022, 6:55 PM

Corrected previous comment.

imp accepted this revision.Jun 8 2022, 7:40 PM

Thanks for synthesizing this into something simple Ed.

Closed by commit rGe3709cfe6a2a: Add SPLIT_KERNEL_DEBUG knob (authored by emaste). · Explain WhyJun 8 2022, 9:16 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe3709cfe6a2a: Add SPLIT_KERNEL_DEBUG knob.
emaste added a commit: rG0c4d13c521aa: Add SPLIT_KERNEL_DEBUG knob.Jul 18 2022, 3:03 PM

Revision Contents
Changeset List

PathSize
share/
man/
man5/
sys/
conf/
5 lines
4 lines
tools/
build/
options/
5 lines
3 lines

Diff 106773

View Options

share/man/man5/src.conf.5

Loading...
View Options

sys/conf/kern.opts.mk

Loading...
View Options

sys/conf/kmod.mk

Loading...
View Options

tools/build/options/WITHOUT_KERNEL_SYMBOLS

Loading...
View Options

tools/build/options/WITHOUT_SPLIT_KERNEL_DEBUG

Loading...