build: Enable building and installing DTrace tests by default
Needs ReviewPublic
Actions

Authored by lwhsu on Sun, Jun 28, 1:12 AM.

Details

Reviewers

markj
emaste
gnn

Group Reviewers

DTrace

Summary

build: Enable building and installing DTrace tests by default

All tests (not skipped by default) pass now.

Event:		Halifax Hackathon 202606
Location:	YYZ Terminal Link
Sponsored by:	The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74345
Build 71228: arc lint + arc unit

Event Timeline

lwhsu created this revision.Sun, Jun 28, 1:12 AM

Herald added a reviewer: gnn. · View Herald TranscriptSun, Jun 28, 1:12 AM

Herald added subscribers: ziaee, imp, bdrewery. · View Herald Transcript

lwhsu requested review of this revision.Sun, Jun 28, 1:12 AM

Harbormaster completed remote builds in B74345: Diff 180845.Sun, Jun 28, 1:13 AM

I have no objection to this but:

I believe the dtrace tests do not run in parallel today. I'm not sure what's involved in fixing that, but it's a lot of extra testing time for a specific component of the system. It takes about an hour to run the dtrace tests on my system, versus about 40 minutes to run the full test suite with parallelism=16. So I will modify my test runner to disable DTrace tests by default; it already has a separate target for the dtrace test suite, as well as zfs, stress2, etc..
Did you verify that all tests pass on all platforms? I suspect you only tested amd64.
Did you verify that all the tests pass with GENERIC-KASAN and GENERIC-KMSAN kernels on amd64? I spent some time getting dtrace to work with sanitizers enabled, but I'm not sure how stable the test suite is with them.