linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c
ClosedPublic
Actions

Authored by imp on Apr 4 2022, 5:04 PM.

Details

Reviewers

Commits

rG20f0a3ac5be4: linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c
rG4859994c4295: linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c
rG1cdb25340f8e: linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c

Summary

Both pci_request_region and _lkpi_pci_iomap encode the size of struct
pci_mmio_region into their code. Move from .h to .c files to move that
knowledge from the client drivers into the linuxkpi module.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 4 2022, 5:04 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:04 PM

imp requested review of this revision.Apr 4 2022, 5:04 PM

Harbormaster completed remote builds in B44991: Diff 104571.Apr 4 2022, 5:04 PM

imp added a parent revision: D34772: linuxkpi: Move lkpi_pci_devres_get_alloc into .c file.Apr 4 2022, 5:04 PM

imp added a child revision: D34774: linuxkpi: Move pci_alloc_irq_vectors to .c file.

• hselasky accepted this revision.Apr 4 2022, 5:20 PM

• hselasky added a subscriber: • hselasky.

• hselasky added inline comments.

sys/compat/linuxkpi/common/src/linux_pci.c
758	Maybe _lkpi_pci_request_region will be required. Make sure LINT passes.

This revision is now accepted and ready to land.Apr 4 2022, 5:20 PM

imp added inline comments.Apr 4 2022, 7:56 PM

sys/compat/linuxkpi/common/src/linux_pci.c
758	I don't think we need this since FreeBSD doesn't have a conflicting global symbol. LINT on x86 passes and a grep shows no conflicts: just linuxkpi drivers and this definition.