Details

Reviewers

emaste
• hselasky

Commits

rGf6f168a17ec2: linuxkpi: Move device_create_groups_vargs to linux_compat.c
rG417f1c81491a: linuxkpi: Move device_create_groups_vargs to linux_compat.c
rG702b68750359: linuxkpi: Move device_create_groups_vargs to linux_compat.c

Summary

device_create_groups_vargs encodes the size of struct device. Move
definition from .h to .c to move this size into the linuxkpi module
rather than encoding it in all client driver modules.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 4 2022, 5:03 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:03 PM

imp requested review of this revision.Apr 4 2022, 5:03 PM

Harbormaster completed remote builds in B44986: Diff 104566.Apr 4 2022, 5:03 PM

imp added a parent revision: D34767: linuxkpi: move kobject_create to .c file.Apr 4 2022, 5:03 PM

imp added a child revision: D34769: linuxkpi: Move class_create to .c file.

emaste accepted this revision.Apr 4 2022, 5:13 PM

emaste added inline comments.

sys/compat/linuxkpi/common/src/linux_compat.c
470	style(9)
496	style(9)

This revision is now accepted and ready to land.Apr 4 2022, 5:13 PM

Looks good and the style issues.

imp added inline comments.Apr 4 2022, 7:49 PM

sys/compat/linuxkpi/common/src/linux_compat.c
470	This is a verbatim copy of the old code. I'd rather not make any other changes to it, lest I introduce bugs (here and below). linuxkpi isn't very style(9) compliant on some things :(