linuxkpi: Move pci_alloc_irq_vectors to .c file
ClosedPublic
Actions

Authored by imp on Apr 4 2022, 5:04 PM.

Details

Reviewers

Commits

rGebd35d1ceb36: linuxkpi: Move pci_alloc_irq_vectors to .c file
rGbc01b383945c: linuxkpi: Move pci_alloc_irq_vectors to .c file
rG36b5c440028b: linuxkpi: Move pci_alloc_irq_vectors to .c file

Summary

pci_alloc_irq_vectors encodes the size of struct msix_entry
into its code. Move from .h to .c to move this knowledge from
client modules to linuxkpi module.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 4 2022, 5:04 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:04 PM

imp requested review of this revision.Apr 4 2022, 5:04 PM

Harbormaster completed remote builds in B44992: Diff 104572.Apr 4 2022, 5:04 PM

imp added a parent revision: D34773: linuxkpi: Move pci_request_region and _lkpi_pci_iomap into .c.Apr 4 2022, 5:04 PM

imp added a child revision: D34775: linuxkpi: Move lkpi_pcim_iomap_devres_find to .c file.

Maybe prefix those functions with lkpi_xxx

This revision is now accepted and ready to land.Apr 4 2022, 5:21 PM

In D34774#788093, @hselasky wrote:

Maybe prefix those functions with lkpi_xxx

The current code is a bit inconsistent about this sort of thing. What's the rule we should enforce?

Closed by commit rG36b5c440028b: linuxkpi: Move pci_alloc_irq_vectors to .c file (authored by imp). · Explain WhyApr 5 2022, 5:10 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG36b5c440028b: linuxkpi: Move pci_alloc_irq_vectors to .c file.

imp added a commit: rGbc01b383945c: linuxkpi: Move pci_alloc_irq_vectors to .c file.Apr 5 2022, 2:43 PM

imp added a commit: rGebd35d1ceb36: linuxkpi: Move pci_alloc_irq_vectors to .c file.Apr 6 2022, 5:46 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

pci.h

38 lines

src/

linux_pci.c

36 lines

Diff 104607

View Options

sys/compat/linuxkpi/common/include/linux/pci.h