Page MenuHomeFreeBSD

sound: Whitespace cleanup
ClosedPublic

Authored by emaste on Wed, Oct 7, 2:29 PM.
Tags
None
Referenced Files
F175287321: D60442.diff
Fri, Oct 9, 4:56 PM
F175280353: D60442.id189153.diff
Fri, Oct 9, 4:12 PM
F175232983: D60442.id188972.diff
Fri, Oct 9, 7:28 AM
F175155790: D60442.id188972.diff
Thu, Oct 8, 5:39 PM
F175155763: D60442.id.diff
Thu, Oct 8, 5:39 PM
Unknown Object (File)
Thu, Oct 8, 9:26 AM
Unknown Object (File)
Thu, Oct 8, 1:12 AM
Unknown Object (File)
Thu, Oct 8, 1:09 AM
Subscribers

Details

Summary

I can't recall what prompted me to take a look at this now, but clean up whitespace in advance of future sound(4) work

Test Plan
$ git diff -w HEAD^
$

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Wed, Oct 7, 2:29 PM
emaste created this revision.

Please make sure to MFC this. Thanks.

This revision is now accepted and ready to land.Wed, Oct 7, 4:54 PM

I've prepared the MFC and will commit shortly.

There were conflicts in four files -- I'll check if those have outstanding commits to MFC and check with you on those first.

sys/dev/sound/macio/davbus.c
sys/dev/sound/pci/solo.c
sys/dev/sound/pcm/channel.c
sys/dev/sound/pcm/dsp.c

Unmerged changes in conflicting files are:

Ready for MFC (based on tag):
2793e5498dd9 sound: Use uint8_t instead of legacy u_char
32137c41065c sound: Retire the version constants (I suspect we don't want to MFC this change though)

Tagged for MFC but not yet time:
13fcc9caaf96 sound: Standardize mixer_init() call order
1a31ab15e8b3 sound: Use snddev_info->lock in place of snd_mixer->lock
221babdf9feb sound: Simplify how snd_mixer is fetched and how the cdev is created
25faf861089c pcm.4: Remove DIAGNOSTICS section
9354e204f5ac sound: Force-disable hw.snd.compat_linux_mmap by default
a614c07ad452 sound: Embed mixer cdev in snd_mixer

SA changes (already merged, no cherry-pick annotation):
1b775b9ea4c1 sound: Fix software buffer lifetime issues
1bb8212df187 sound: Check for offset overflow in dsp_mmap_single()
62c4afcb4604 dsp: Fix a potential use-after-free in dsp_oss_syncstart()

Not to be MFC'd:
a6aa95eba6ee sound: Create all device nodes with GID_AUDIO

Other:
e254ef87a30b sound: Merge chn_intr() with chn_intr_locked()
5cc34a83e1cc Revert "sound: Merge chn_intr() with chn_intr_locked()"

There are a bunch of commits on Sept. 18 with a 1 month MFC timeout indicated. I'll plan to MFC this whitespace change immediately after those land.

I am aware of the first 2 MFCs, I'm holding off to commit them along with the 1 month ones.

This revision was automatically updated to reflect the committed changes.