rtwn: add support for the RTL8723BU

[vexeduxr]

Vendor driver used for reference: https://github.com/lwfinger/rtl8723bu

[ziaee]

share/man/man4/rtwn.4

273

In roff each sentence should start on a new line, or the linter will complain.

share/man/man4/rtwn_usb.4

120

This list is 'consumer name' - 'chipset name', so this doesn't look right?

[vexeduxr]

share/man/man4/rtwn_usb.4

120

In this case the consumer is Realtek themselves, not a third party. There are a couple other entries in the list like this.

[vexeduxr]

Move sentence to its own line

[vexeduxr]

Move entry to the correct place in the hardware list

[ziaee]

No comment on rest of implementation, but manpage looks good to me.

[adrian]

i'm pretty sure we can check in binary files nowdays; i won't do it as part of this commit but I'll go review moving the uuencoded firmware files to binary files in a separate diff.

[adrian]

sys/dev/rtwn/rtl8723b/r23b_calib.c

5

is there any reason not to use your @freebsd.org account?

sys/dev/rtwn/rtl8812a/r12a_tx_desc.h

118

which field in txdw6 ? Add a comment on which bitfields to tinker with later.

[vexeduxr]

sys/dev/rtwn/rtl8723b/r23b_calib.c

5

I guess not. There are files in the tree marked with this email from before I got a commit bit, and I wanted to remain consistent.

Maybe I should just change the older ones...

[vexeduxr]

Change email in copyright notices and document which bits of txdw6 are passed through.

[ziaee]

sys/dev/rtwn/rtl8723b/r23b_calib.c

2–27

While we're doing the copyright dance, we updated the preferred license representation for new files, please take a look: https://docs.freebsd.org/en/articles/license-guide/

Notes:

1. the hyphen at the beginning is removed, that was for a project which never worked and abandoned long ago
2. copyright line comes first
3. the entire text of the license is already included with freebsd so it does not need to be duplicated since we can express it unambiguously. this is in line ISO standards and also is what linux does.

sys/dev/rtwn/rtl8723b/r23b_fw.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_fw_cmd.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_init.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_led.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_priv.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_reg.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rf.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom_defs.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rom_image.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_rx.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/r23b_var.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu.h

2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu_attach.c

2–27

Ditto

sys/dev/rtwn/rtl8723b/usb/r23bu_init.c

2

No hyphen here

sys/dev/rtwn/rtl8723b/usb/r23bu_rom.c

2–27

Ditto

[vexeduxr]

sys/dev/rtwn/rtl8723b/r23b_calib.c

2–27

Ah, I do vaguely remember reading about that. I'll fix it up.

Thanks.

[vexeduxr]

Update license text.

Also move the 8723b entry to the correct place in the Makefiles and include
header files in SRCS.

[ziaee]

Thanks! No comment on rest of implementation, but manpage looks good to me!

[avos]

Looks good to me

[adrian]

boot tested on this laptop; associated and works. Getting 10mbit down and 6mbit up on speedtest.net speedtest on my busy 2GHz air. It looks like it hovers around MCS3/MCS4 here but that's likely distance/busy air.

rtwn0: <Realtek 802.11n WLAN Adapter, class 239/2, rev 2.10/2.00, addr 1> on usbus0
rtwn0: MAC/BB RTL8723BU, RF 6052 1T1R

So yup, approved! please land it when you're ready.