vm_phys: Add a sysctl to dump registered fictitious memory ranges
ClosedPublic
Actions

Authored by markj on Thu, Jul 16, 2:03 PM.

Details

Reviewers

kib
alc
dougm
andrew
manu

Commits

rGa7e483ee146a: vm_phys: Add a sysctl to dump registered fictitious memory ranges

Summary

I've wanted this a couple of times in the past. Save the memattr in
the fictitious memory segment structure so that we can report it from
the sysctl handler, and add conversion routines for each platform.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Thu, Jul 16, 2:03 PM

Herald added a reviewer: andrew. · View Herald TranscriptThu, Jul 16, 2:03 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

markj requested review of this revision.Thu, Jul 16, 2:03 PM

Harbormaster completed remote builds in B74849: Diff 182078.Thu, Jul 16, 2:03 PM

kib added inline comments.Thu, Jul 16, 2:32 PM

sys/vm/vm_phys.c
372	The why not return "???" from vm_memattr_name()? I would print the numeric value of the unknown memattr.

Print a number if memattr decoding fails

markj marked an inline comment as done.Thu, Jul 16, 3:03 PM

markj added inline comments.

sys/vm/vm_phys.c
372	The why not return "???" from vm_memattr_name()? Returning NULL indicates that the memattr was not decoded, it seems better to give that extra information to the caller and let them decide how to handle it. I would print the numeric value of the unknown memattr. Ok