Differential D56982

linux: Fix some problems with header pollution
ClosedPublic
Actions

Authored by markj on Wed, May 13, 12:41 AM.

Tags

None

Referenced Files

	F157045448: D56982.diff
	Mon, May 18, 2:56 AM

	F156987408: D56982.diff
	Sun, May 17, 8:00 PM

	F156971616: D56982.id177866.diff
	Sun, May 17, 5:33 PM

	F156971578: D56982.id177866.diff
	Sun, May 17, 5:32 PM

	Unknown Object (File)
	Sat, May 16, 11:40 PM

	Unknown Object (File)
	Fri, May 15, 12:47 PM

	Unknown Object (File)
	Fri, May 15, 10:26 AM

	Unknown Object (File)
	Thu, May 14, 8:11 PM

View All 9 Files

Subscribers

Details

Reviewers

kib
dchagin
olce
andrew
manu
emaste
imp

Commits

rGb99954433d42: linux: Fix some problems with header pollution

Summary

Avoid including sys/proc.h in linux_vdso_gtod.c. It's not needed, but the implicit inclusion of sys/param.h via sys/ucred.h->bsm/audit.h was bringing in some required definitions.
Include a couple of required headers: sys/time.h (for struct bintime), and limits.h (for INT_MAX).
Move some helpers from linux.h, which depend on sys/param.h for NODEV, to the one CU where they're actually used.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Wed, May 13, 12:41 AM

Herald added a reviewer: andrew. · View Herald TranscriptWed, May 13, 12:41 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

markj requested review of this revision.Wed, May 13, 12:41 AM

Harbormaster completed remote builds in B73063: Diff 177723.Wed, May 13, 12:41 AM

kib accepted this revision.Wed, May 13, 12:51 AM

This revision is now accepted and ready to land.Wed, May 13, 12:51 AM

emaste accepted this revision.Wed, May 13, 12:54 AM

Does this let us take anything out of badfiles.inc?

In D56982#1305794, @imp wrote:

Does this let us take anything out of badfiles.inc?

No, this is a step towards landing D56993, which fixes a problem that caused me a bunch of pain a while ago.

Closed by commit rGb99954433d42: linux: Fix some problems with header pollution (authored by markj). · Explain WhyFri, May 15, 1:11 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGb99954433d42: linux: Fix some problems with header pollution.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

linux_vdso_gtod.c

4 lines

linux32/

linux32_vdso_gtod.c

4 lines

arm64/

linux/

linux_vdso_gtod.c

4 lines

compat/

linux/

50 lines

46 lines

i386/

linux/

linux_vdso_gtod.c

4 lines

Diff 177866

sys/amd64/linux/linux_vdso_gtod.c

Loading...

sys/amd64/linux32/linux32_vdso_gtod.c

Loading...

sys/arm64/linux/linux_vdso_gtod.c

Loading...

sys/compat/linux/linux.h

Loading...

sys/compat/linux/linux_stats.c

Loading...

sys/i386/linux/linux_vdso_gtod.c

Loading...