Page MenuHomeFreeBSD

ucred.h: Do not include audit.h unconditionally
Needs ReviewPublic

Authored by markj on May 13 2026, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 3:04 AM
Unknown Object (File)
Mon, Jun 8, 10:10 AM
Unknown Object (File)
Sat, May 30, 10:10 PM
Unknown Object (File)
Mon, May 25, 7:25 AM
Unknown Object (File)
May 24 2026, 1:02 PM
Unknown Object (File)
May 22 2026, 11:53 AM
Unknown Object (File)
May 22 2026, 12:39 AM
Unknown Object (File)
May 21 2026, 11:47 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

audit.h is included because struct ucred embeds a struct auditinfo_addr,
which is defined in audit.h. But struct ucred is not visible to
userspace by default, so we shouldn't be including audit.h by default
either, especially since audit.h pulls in param.h, which pollutes the
namespace. (In particular it pulls in machine/param.h, which #defines
"MACHINE", which makes the QEMU build unhappy.)

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73082
Build 69965: arc lint + arc unit