Makefile.inc1: Always use ${PKG_CMD}
ClosedPublic
Actions

Authored by ivy on Apr 27 2026, 4:44 AM.

Tags

None

Referenced Files

	F165174574: D56655.id.diff
	Thu, Aug 6, 1:50 PM

	Unknown Object (File)
	Wed, Aug 5, 4:09 AM

	Unknown Object (File)
	Sun, Aug 2, 3:10 AM

	Unknown Object (File)
	Sun, Aug 2, 1:35 AM

	Unknown Object (File)
	Sat, Aug 1, 7:41 AM

	Unknown Object (File)
	Sat, Aug 1, 12:11 AM

	Unknown Object (File)
	Fri, Jul 31, 2:06 AM

	Unknown Object (File)
	Mon, Jul 27, 3:17 AM

View All 44 Files

Subscribers

emaste

imp

Details

Reviewers

wosch
emaste

Group Reviewers

pkgbase

Commits

rGd2ce6ed7f553: Makefile.inc1: Always use ${PKG_CMD}
rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD}

Summary

Previously we had a mix of ${PKG_CMD} and bare 'pkg', which is
wrong, and breaks the build when 'pkg' isn't in the tools path,
e.g. when cross-building.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Apr 27 2026, 4:44 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 27 2026, 4:44 AM

ivy requested review of this revision.Apr 27 2026, 4:44 AM

Harbormaster completed remote builds in B72562: Diff 176604.Apr 27 2026, 4:44 AM

wosch accepted this revision.Apr 27 2026, 8:25 AM

This revision is now accepted and ready to land.Apr 27 2026, 8:25 AM

emaste accepted this revision.Apr 27 2026, 2:20 PM

Closed by commit rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD} (authored by ivy). · Explain WhyApr 27 2026, 10:06 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGb866d05ea286: Makefile.inc1: Always use ${PKG_CMD}.

ivy added a commit: rGd2ce6ed7f553: Makefile.inc1: Always use ${PKG_CMD}.Sat, Jul 25, 1:08 PM

Revision Contents
Changeset List

Path

Size

Makefile.inc1

8 lines

Diff 176679

View Options

Makefile.inc1: Always use ${PKG_CMD}ClosedPublicActions