Page MenuHomeFreeBSD
Differential D55641

pmc: Import Intel Meteor Lake events
ClosedPublic
Actions

Authored by bnovkov on Tue, Mar 3, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 25, 10:31 PM
Unknown Object (File)
Tue, Mar 24, 7:52 AM
Unknown Object (File)
Fri, Mar 20, 8:48 AM
Unknown Object (File)
Fri, Mar 13, 1:29 AM
Unknown Object (File)
Sat, Mar 7, 7:20 PM
Unknown Object (File)
Fri, Mar 6, 3:30 PM
Unknown Object (File)
Fri, Mar 6, 1:36 PM
Unknown Object (File)
Thu, Mar 5, 8:36 AM
View All 10 Files
Subscribers
imp

Details

Reviewers
gnn
ali_mashtizadeh.com
mhorne
Group Reviewers
pmc
Commits
rGcb9e24221672: pmc: Import Intel Meteor Lake events
Summary

Obtained from: Intel perfmon (JSON event definitions)
Tested by: bms, olivier
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bnovkov created this revision.Tue, Mar 3, 9:46 PM
Herald added a reviewer: gnn. · View Herald TranscriptTue, Mar 3, 9:46 PM
Herald added a reviewer: ali_mashtizadeh.com. · View Herald Transcript
Herald added a subscriber: imp. · View Herald Transcript
bnovkov requested review of this revision.Tue, Mar 3, 9:46 PM
Harbormaster completed remote builds in B71165: Diff 173086.Tue, Mar 3, 9:46 PM
mhorne accepted this revision.Wed, Mar 11, 2:01 PM
This revision is now accepted and ready to land.Wed, Mar 11, 2:01 PM
ali_mashtizadeh.com accepted this revision.Wed, Mar 11, 7:09 PM

Looks good to me, just be aware that I landed a fix that forces us to whitelist json fields. I don't see any new fields but you should check that it builds against head as of bfb2fd5f66183454cfe8771595df09c0f23c7efb

bnovkov added a parent revision: D56017: libpmc/pmu-events: Add support for new json fields.Sat, Mar 21, 2:42 PM
In D55641#1276922, @ali_mashtizadeh.com wrote:

Looks good to me, just be aware that I landed a fix that forces us to whitelist json fields. I don't see any new fields but you should check that it builds against head as of bfb2fd5f66183454cfe8771595df09c0f23c7efb

Thank you for the heads-up, it turns out that three new JSON fields have been introduced in mtl-metrics.json.
I've opened a separate revision to add those to jevents.c: D56017

Closed by commit rGcb9e24221672: pmc: Import Intel Meteor Lake events (authored by bnovkov). · Explain WhyTue, Mar 24, 10:38 AM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rGcb9e24221672: pmc: Import Intel Meteor Lake events.

Revision Contents
Changeset List

PathSize
lib/
libpmc/
pmu-events/
arch/
x86/
3 lines
meteorlake/
1733 lines
368 lines
623 lines
499 lines
2825 lines
90 lines
2096 lines
20 lines
66 lines
160 lines
10 lines
377 lines
sys/
dev/
hwpmc/
6 lines
sys/
1 line

Diff 174206

View Options

lib/libpmc/pmu-events/arch/x86/mapfile.csv

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/cache.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/floating-point.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/frontend.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/memory.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/mtl-metrics.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/other.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/pipeline.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/uncore-cache.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/uncore-interconnect.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/uncore-memory.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/uncore-other.json

Loading...
View Options

lib/libpmc/pmu-events/arch/x86/meteorlake/virtual-memory.json

Loading...
View Options

sys/dev/hwpmc/hwpmc_intel.c

Loading...
View Options

sys/sys/pmc.h

Loading...