libpmc/pmu-events: Add support for new json fields
ClosedPublic
Actions

Authored by bnovkov on Sat, Mar 21, 2:41 PM.

Details

Reviewers

ali_mashtizadeh.com
mhorne

Group Reviewers

pmc

Commits

rG6ad94d549eb2: libpmc/pmu-events: Add support for new json fields

Summary

This change adds support for three new Intel fields to jevents.c:

MetricThreshold
MetricgroupNoGroup
DefaultMetricgroupName

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bnovkov created this revision.Sat, Mar 21, 2:41 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 21, 2:41 PM

bnovkov requested review of this revision.Sat, Mar 21, 2:41 PM

Harbormaster completed remote builds in B71625: Diff 174082.Sat, Mar 21, 2:41 PM

bnovkov added a child revision: D55641: pmc: Import Intel Meteor Lake events.Sat, Mar 21, 2:42 PM

bnovkov mentioned this in D55641: pmc: Import Intel Meteor Lake events.

The change looks good overall, but do we need to do anything with these fields or it's just annotations for the user?

What's the group name is that to make it easier to search types of counters? I can add that into the tooling changes I'm working on.

Ah I realize this is for the formulas they provide. Looks good.

This revision is now accepted and ready to land.Mon, Mar 23, 3:52 AM

mhorne accepted this revision.Mon, Mar 23, 2:02 PM

Closed by commit rG6ad94d549eb2: libpmc/pmu-events: Add support for new json fields (authored by bnovkov). · Explain WhyTue, Mar 24, 10:38 AM

This revision was automatically updated to reflect the committed changes.

bnovkov added a commit: rG6ad94d549eb2: libpmc/pmu-events: Add support for new json fields.

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

pmu-events/

jevents.c

24 lines

pmu-events.h

3 lines

Diff 174207

View Options

lib/libpmc/pmu-events/jevents.c