Differential D55058

ip_mroute: Try to make function pointer declarations more consistent
ClosedPublic
Actions

Authored by markj on Feb 2 2026, 5:30 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent

Summary

The ip_mroute and ip6_mroute modules hook into the network stack via
several function pointers. Declarations for these pointers are
scattered around several headers. Put them all in the same place,
ip(6)_mroute.h.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 2 2026, 5:30 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptFeb 2 2026, 5:30 PM

markj requested review of this revision.Feb 2 2026, 5:30 PM

markj added a parent revision: D55057: ip_mroute: Use a local variable to store a VIF pointer.

Harbormaster completed remote builds in B70349: Diff 171011.Feb 2 2026, 5:30 PM

markj added a child revision: D55059: ip6_mroute: Deindent some code in ip6_mdq().Feb 2 2026, 5:30 PM

glebius accepted this revision as: glebius.Feb 2 2026, 5:46 PM

glebius added inline comments.

sys/netinet/ip_mroute.h
362–366	I don't think any modern compiler actually needs this any more.

This revision is now accepted and ready to land.Feb 2 2026, 5:46 PM

Closed by commit rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent (authored by markj). · Explain WhyFeb 10 2026, 1:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

1 line

1 line

1 line

21 lines

1 line

10 lines

netinet6/

1 line

14 lines

1 line

2 lines

1 line

Diff 171641

View Options

sys/netinet/igmp.c

View Options

sys/netinet/in_mcast.c

View Options

sys/netinet/ip_input.c

View Options

sys/netinet/ip_mroute.h

View Options

sys/netinet/ip_output.c

View Options

sys/netinet/ip_var.h

View Options

sys/netinet6/ip6_input.c

View Options

sys/netinet6/ip6_mroute.h

View Options

sys/netinet6/ip6_output.c

View Options

sys/netinet6/ip6_var.h

View Options

ip_mroute: Try to make function pointer declarations more consistentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 171641

sys/netinet/igmp.c

sys/netinet/in_mcast.c

sys/netinet/ip_input.c

sys/netinet/ip_mroute.h

sys/netinet/ip_output.c

sys/netinet/ip_var.h

sys/netinet6/ip6_input.c

sys/netinet6/ip6_mroute.h

sys/netinet6/ip6_output.c

sys/netinet6/ip6_var.h

sys/netinet6/mld6.c

ip_mroute: Try to make function pointer declarations more consistent
ClosedPublic
Actions

Revision Contents
Changeset List