Page MenuHomeFreeBSD
Differential D55058

ip_mroute: Try to make function pointer declarations more consistent
ClosedPublic
Actions

Authored by markj on Feb 2 2026, 5:30 PM.
Tags
None
Referenced Files
F162634792: D55058.diff
Wed, Jul 15, 7:05 AM
F162634791: D55058.diff
Wed, Jul 15, 7:05 AM
Unknown Object (File)
Sat, Jul 11, 7:53 AM
Unknown Object (File)
Thu, Jul 9, 9:58 PM
Unknown Object (File)
Thu, Jul 9, 6:55 PM
Unknown Object (File)
Fri, Jun 19, 10:50 AM
Unknown Object (File)
Fri, Jun 19, 5:16 AM
Unknown Object (File)
Jun 1 2026, 2:34 PM
View All 45 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
glebius
pouria
Group Reviewers
network
Commits
rGd94862ceb2b0: ip_mroute: Try to make function pointer declarations more consistent
rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent
Summary

The ip_mroute and ip6_mroute modules hook into the network stack via
several function pointers. Declarations for these pointers are
scattered around several headers. Put them all in the same place,
ip(6)_mroute.h.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Feb 2 2026, 5:30 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptFeb 2 2026, 5:30 PM
markj requested review of this revision.Feb 2 2026, 5:30 PM
markj added a parent revision: D55057: ip_mroute: Use a local variable to store a VIF pointer.
Harbormaster completed remote builds in B70349: Diff 171011.Feb 2 2026, 5:30 PM
markj added a child revision: D55059: ip6_mroute: Deindent some code in ip6_mdq().Feb 2 2026, 5:30 PM
glebius accepted this revision as: glebius.Feb 2 2026, 5:46 PM
glebius added inline comments.
sys/netinet/ip_mroute.h
362–366

I don't think any modern compiler actually needs this any more.

This revision is now accepted and ready to land.Feb 2 2026, 5:46 PM
Closed by commit rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent (authored by markj). · Explain WhyFeb 10 2026, 1:51 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG9df6a7f9a60b: ip_mroute: Try to make function pointer declarations more consistent.
markj added a commit: rGd94862ceb2b0: ip_mroute: Try to make function pointer declarations more consistent.Mar 31 2026, 3:59 PM
Herald added a reviewer: pouria. · View Herald TranscriptMar 31 2026, 3:59 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line
1 line
1 line
21 lines
1 line
10 lines
netinet6/
1 line
14 lines
1 line
2 lines
1 line

Diff 171641

View Options

sys/netinet/igmp.c

Loading...
View Options

sys/netinet/in_mcast.c

Loading...
View Options

sys/netinet/ip_input.c

Loading...
View Options

sys/netinet/ip_mroute.h

Loading...
View Options

sys/netinet/ip_output.c

Loading...
View Options

sys/netinet/ip_var.h

Loading...
View Options

sys/netinet6/ip6_input.c

Loading...
View Options

sys/netinet6/ip6_mroute.h

Loading...
View Options

sys/netinet6/ip6_output.c

Loading...
View Options

sys/netinet6/ip6_var.h

Loading...
View Options

sys/netinet6/mld6.c

Loading...