Differential D54840

sys: Use __is_aligned and __align_down for some kstack alignment operations
ClosedPublic
Actions

Authored by jhb on Jan 23 2026, 6:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 12:22 AM

	Unknown Object (File)
	Thu, Sep 3, 3:57 PM

	Unknown Object (File)
	Thu, Sep 3, 3:51 PM

	Unknown Object (File)
	Thu, Sep 3, 3:45 PM

	Unknown Object (File)
	Wed, Aug 26, 9:01 PM

	Unknown Object (File)
	Wed, Aug 26, 6:01 AM

	Unknown Object (File)
	Wed, Aug 26, 3:54 AM

	Unknown Object (File)
	Tue, Aug 25, 8:44 AM

View All 74 Files

Subscribers

Details

Reviewers

jhibbits
adrian
fuz
kib

Group Reviewers

Commits

rGf5b85cc09186: sys: Use __is_aligned and __align_down for some kstack alignment operations
rG093fffa296d0: sys: Use __is_aligned and __align_down for some kstack alignment operations

Summary

Effort: CHERI upstreaming
Sponsored by: AFRL, DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 23 2026, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2026, 6:45 PM

jhb requested review of this revision.Jan 23 2026, 6:45 PM

Herald added a reviewer: cheri. · View Herald TranscriptJan 23 2026, 6:45 PM

Harbormaster completed remote builds in B70078: Diff 170283.Jan 23 2026, 6:45 PM

jhb added a parent revision: D54839: powerpc: Fix alignment of initial PCB on kstack.Jan 23 2026, 6:45 PM

jhb added a reviewer: kib.Jan 23 2026, 6:46 PM

kib accepted this revision.Jan 23 2026, 6:50 PM

This revision is now accepted and ready to land.Jan 23 2026, 6:50 PM

Note: you can test this for ppc64 by using power8/power9 VMs:

https://wiki.freebsd.org/powerpc/QEMU/Pseries8

https://wiki.freebsd.org/powerpc/QEMU/Pseries9

(I'm still working on fixing up what's broken for ppc970 (g5) and powerpc 32 bit on g3/g4 CPUs in QEMU)

jhibbits accepted this revision.Jan 25 2026, 3:07 AM

In D54840#1253684, @adrian wrote:

Note: you can test this for ppc64 by using power8/power9 VMs:

https://wiki.freebsd.org/powerpc/QEMU/Pseries8

https://wiki.freebsd.org/powerpc/QEMU/Pseries9

(I'm still working on fixing up what's broken for ppc970 (g5) and powerpc 32 bit on g3/g4 CPUs in QEMU)

I only really tested that this compiled for powerpc. These are some fixes I found while working on some larger tree-sweeps for CHERI that involve replacing vm_offset_t with void * in various APIs.

Closed by commit rG093fffa296d0: sys: Use __is_aligned and __align_down for some kstack alignment operations (authored by jhb). · Explain WhyJan 27 2026, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG093fffa296d0: sys: Use __is_aligned and __align_down for some kstack alignment operations.

jhb added a commit: rGf5b85cc09186: sys: Use __is_aligned and __align_down for some kstack alignment operations.Apr 24 2026, 3:29 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

3 lines

i386/

i386/

3 lines

powerpc/

powerpc/

4 lines

5 lines

4 lines

Diff 170546

sys/amd64/amd64/vm_machdep.c

Loading...

sys/i386/i386/vm_machdep.c

Loading...

sys/powerpc/powerpc/exec_machdep.c

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/powerpc/powerpc/vm_machdep.c

Loading...