Page MenuHomeFreeBSD
Differential D53656

stand: Rename EFI_ERROR_CODE to DECODE_ERROR to avoid Edk2 Clash
ClosedPublic
Actions

Authored by imp on Mon, Nov 10, 2:38 AM.
Tags
None
Referenced Files
F136752400: D53656.id166102.diff
Wed, Nov 19, 6:52 AM
F136727837: D53656.id166181.diff
Wed, Nov 19, 2:27 AM
F136711623: D53656.diff
Wed, Nov 19, 12:20 AM
Unknown Object (File)
Sun, Nov 16, 6:27 PM
Unknown Object (File)
Sat, Nov 15, 3:37 PM
Unknown Object (File)
Fri, Nov 14, 8:08 AM
Unknown Object (File)
Fri, Nov 14, 8:06 AM
Unknown Object (File)
Fri, Nov 14, 7:14 AM
View All 19 Files
Subscribers
bcran
dab

Details

Reviewers
manu
kevans
tsoome
Commits
rG87795c6e95b0: stand: Rename EFI_ERROR_CODE to DECODE_ERROR to avoid Edk2 Clash
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68491
Build 65374: arc lint + arc unit

Event Timeline

imp created this revision.Mon, Nov 10, 2:38 AM
Herald added a reviewer: manu. · View Herald TranscriptMon, Nov 10, 2:38 AM
Herald added subscribers: dab, bcran. · View Herald Transcript
imp requested review of this revision.Mon, Nov 10, 2:38 AM
Harbormaster completed remote builds in B68491: Diff 166102.Mon, Nov 10, 2:38 AM
imp added a child revision: D53651: efi: Move edk2 compat defines to sys/efi-edk2.h.Mon, Nov 10, 2:39 AM
imp added reviewers: kevans, tsoome.
tsoome accepted this revision.Mon, Nov 10, 4:11 PM

I used DECODE_ERROR() in illumos loader in pair with ENCODE_ERROR(). (https://github.com/illumos/illumos-gate/commit/f334afcfaebea1b7dc3430015651d8d748fa8a3e).

This revision is now accepted and ready to land.Mon, Nov 10, 4:11 PM
imp retitled this revision from stand: Rename EFI_ERROR_CODE to EFI_ERRCODE to avoid Edk2 Clash to stand: Rename EFI_ERROR_CODE to DECODE_ERROR to avoid Edk2 Clash.Mon, Nov 10, 11:14 PM
imp updated this revision to Diff 166181.Mon, Nov 10, 11:14 PM

Use DECODE_ERROR as the name, as suggested. It's maybe less likely to conflict?

This revision now requires review to proceed.Mon, Nov 10, 11:14 PM
Harbormaster completed remote builds in B68524: Diff 166181.Mon, Nov 10, 11:14 PM
tsoome accepted this revision.Tue, Nov 11, 1:19 PM
This revision is now accepted and ready to land.Tue, Nov 11, 1:19 PM
Closed by commit rG87795c6e95b0: stand: Rename EFI_ERROR_CODE to DECODE_ERROR to avoid Edk2 Clash (authored by imp). · Explain WhySun, Nov 16, 6:29 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG87795c6e95b0: stand: Rename EFI_ERROR_CODE to DECODE_ERROR to avoid Edk2 Clash.

Revision Contents
Changeset List

PathSize
stand/
efi/
boot1/
8 lines
4 lines
2 lines
2 lines
gptboot/
4 lines
include/
2 lines
libefi/
2 lines
2 lines
2 lines
10 lines
4 lines
8 lines
loader/
arch/
amd64/
4 lines
8 lines
6 lines
4 lines
6 lines
2 lines

Diff 166102

View Options

stand/efi/boot1/boot1.c

Loading...
View Options

stand/efi/boot1/proto.c

Loading...
View Options

stand/efi/boot1/ufs_module.c

Loading...
View Options

stand/efi/boot1/zfs_module.c

Loading...
View Options

stand/efi/gptboot/proto.c

Loading...
View Options

stand/efi/include/efierr.h

Loading...
View Options

stand/efi/libefi/devpath.c

Loading...
View Options

stand/efi/libefi/efi_driver_utils.c

Loading...
View Options

stand/efi/libefi/eficom.c

Loading...
View Options

stand/efi/libefi/efinet.c

Loading...
View Options

stand/efi/libefi/efipart.c

Loading...
View Options

stand/efi/libefi/env.c

Loading...
View Options

stand/efi/loader/arch/amd64/multiboot2.c

Loading...
View Options

stand/efi/loader/arch/amd64/trap.c

Loading...
View Options

stand/efi/loader/bootinfo.c

Loading...
View Options

stand/efi/loader/copy.c

Loading...
View Options

stand/efi/loader/framebuffer.c

Loading...
View Options

stand/efi/loader/main.c

Loading...