bhyve/virtio-scsi: unlimit max_sectors
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Oct 30 2025, 7:37 AM.

Details

Reviewers

jhb
corvink
markj

Group Reviewers

bhyve

Commits

rG73ab91aaade5: bhyve/virtio-scsi: Unlimit max_sectors

Summary

The old default of 2 for max_sectors limits performance significantly
with guest systems where the virtio-scsi driver actually honors this
value.

As CTL doesn't seem to have any limit of the maximum size of a single
transfer, set this to INT32_MAX by default.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Oct 30 2025, 7:37 AM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 30 2025, 7:37 AM

Harbormaster completed remote builds in B68261: Diff 165397.Oct 30 2025, 7:37 AM

rosenfeld_grumpf.hope-2000.org requested review of this revision.Oct 30 2025, 7:37 AM

rosenfeld_grumpf.hope-2000.org added a parent revision: D53465: bhyve/virtio: check negotiated_caps for indirect descriptor support.

rosenfeld_grumpf.hope-2000.org added a child revision: D53467: bhyve/virtio-scsi: advertise support for indirect descriptors.

corvink accepted this revision.Nov 3 2025, 7:24 AM

This revision is now accepted and ready to land.Nov 3 2025, 7:24 AM

Closed by commit rG73ab91aaade5: bhyve/virtio-scsi: Unlimit max_sectors (authored by rosenfeld_grumpf.hope-2000.org, committed by emaste). · Explain WhyFri, Feb 6, 2:56 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG73ab91aaade5: bhyve/virtio-scsi: Unlimit max_sectors.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_virtio_scsi.c

3 lines

Diff 171332

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

bhyve/virtio-scsi: unlimit max_sectorsClosedPublicActions