Differential D53465

bhyve/virtio: check negotiated_caps for indirect descriptor support
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Oct 30 2025, 7:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 5, 6:47 PM

	Unknown Object (File)
	Jan 8 2026, 12:21 AM

	Unknown Object (File)
	Jan 6 2026, 5:42 AM

	Unknown Object (File)
	Dec 30 2025, 1:39 PM

	Unknown Object (File)
	Nov 28 2025, 10:19 AM

	Unknown Object (File)
	Nov 22 2025, 6:41 PM

	Unknown Object (File)
	Nov 18 2025, 11:51 AM

	Unknown Object (File)
	Nov 12 2025, 12:10 AM

View All 24 Files

Subscribers

crest_freebsd_rlwinm.de

Details

Reviewers

jhb
corvink
markj

Group Reviewers

Commits

rG5379c4627782: bhyve/virtio: check negotiated_caps for indirect descriptor support

Summary

vq_getchain() erroneously checks vc_hv_caps for indirect descriptor
support when it encounters an indirect descriptor. vc_hv_caps is used
in feature negotiation to advertise what features our device emulation
supports, but we should really check what features we have negotiated
with the driver.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Oct 30 2025, 7:37 AM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 30 2025, 7:37 AM

rosenfeld_grumpf.hope-2000.org requested review of this revision.Oct 30 2025, 7:37 AM

Harbormaster completed remote builds in B68260: Diff 165396.Oct 30 2025, 7:37 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D53466: bhyve/virtio-scsi: unlimit max_sectors.Oct 30 2025, 7:37 AM

corvink accepted this revision.Nov 3 2025, 7:23 AM

This revision is now accepted and ready to land.Nov 3 2025, 7:23 AM

Closed by commit rG5379c4627782: bhyve/virtio: check negotiated_caps for indirect descriptor support (authored by rosenfeld_grumpf.hope-2000.org, committed by emaste). · Explain WhyThu, Feb 5, 6:51 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG5379c4627782: bhyve/virtio: check negotiated_caps for indirect descriptor support.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

2 lines

Diff 171275

usr.sbin/bhyve/virtio.c

Loading...