O requests
Needs ReviewPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Oct 30 2025, 7:38 AM.

Details

Reviewers

jhb
corvink
markj

Group Reviewers

bhyve

Summary

By preallocating all I/O requests on all queues, we can take most
allocations out of the hot I/O code paths and simplify the code
significantly. While here, make sure we check all allocations for
success and make sure to handle failures gracefully.

Additionally, check for I/O request validity as early as possible,
and return illegal requests immediately.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69047
Build 65930: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Oct 30 2025, 7:38 AM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 30 2025, 7:38 AM

rosenfeld_grumpf.hope-2000.org requested review of this revision.Oct 30 2025, 7:38 AM

Harbormaster completed remote builds in B68264: Diff 165400.Oct 30 2025, 7:38 AM

rosenfeld_grumpf.hope-2000.org added a parent revision: D53468: bhyve/virtio: rework iovec handling functions for efficiency and clarity.Oct 30 2025, 7:38 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D53470: bhyve/virtio-scsi: check LUN address validity.

Rebase.

Harbormaster completed remote builds in B68267: Diff 165403.Oct 30 2025, 7:46 AM

pci_vtscsi_proc()

Harbormaster completed remote builds in B68273: Diff 165411.Oct 30 2025, 8:09 AM

Rebase.

Harbormaster completed remote builds in B69047: Diff 167542.Dec 4 2025, 6:21 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_virtio_scsi.c

387 lines

Diff 167542

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

bhyve/virtio-scsi: preallocate all I/O requestsNeeds ReviewPublicActions