Page MenuHomeFreeBSD
Differential D55803

bhyve/virtio-scsi: Don't invoke iov_to_buf() in an assert() expression
Needs ReviewPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Tue, Mar 10, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 12, 3:17 PM
Unknown Object (File)
Wed, Mar 11, 6:22 AM
Unknown Object (File)
Wed, Mar 11, 5:52 AM
Unknown Object (File)
Wed, Mar 11, 3:05 AM
Unknown Object (File)
Wed, Mar 11, 3:00 AM
Subscribers
bcran
des
imp
rgrimes

Details

Reviewers
siva
jhb
markj
emaste
des
Group Reviewers
bhyve
Summary

If anyone would build bhyve with -DNDEBUG, any code in the expression
in assert() won't be executed. Remove the assertion and check the
returned size from iov_to_buf() explicitly, exiting if it is wrong.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71323
Build 68206: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Tue, Mar 10, 7:18 PM
Herald added a reviewer: bhyve. · View Herald TranscriptTue, Mar 10, 7:18 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
rosenfeld_grumpf.hope-2000.org requested review of this revision.Tue, Mar 10, 7:18 PM
Harbormaster completed remote builds in B71321: Diff 173528.Tue, Mar 10, 7:18 PM
rosenfeld_grumpf.hope-2000.org added reviewers: jhb, markj, emaste.Tue, Mar 10, 7:19 PM
emaste added inline comments.Tue, Mar 10, 7:22 PM
usr.sbin/bhyve/pci_virtio_scsi.c
753
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173530.Tue, Mar 10, 7:25 PM
rosenfeld_grumpf.hope-2000.org marked an inline comment as done.

Review from emaste.

Harbormaster completed remote builds in B71323: Diff 173530.Tue, Mar 10, 7:25 PM
siva mentioned this in D55795: bhyve/virtio-scsi: fix sign-compare warning on gcc15.Tue, Mar 10, 8:02 PM
des requested changes to this revision.Wed, Mar 11, 12:28 PM
des added a subscriber: des.
des added inline comments.
usr.sbin/bhyve/pci_virtio_scsi.c
751

This still fails to build with gcc.

This revision now requires changes to proceed.Wed, Mar 11, 12:28 PM
rosenfeld_grumpf.hope-2000.org added inline comments.Wed, Mar 11, 12:45 PM
usr.sbin/bhyve/pci_virtio_scsi.c
751

That's not surprising, given this is a fix for a different issue. Please see https://reviews.freebsd.org/D55800 for the proper fix of the build failure with gcc.

des resigned from this revision.Wed, Mar 11, 12:52 PM
des added a parent revision: D55800: bhyve/virtio: Fix comparison of integer expressions of different signedness.
This revision now requires review to proceed.Wed, Mar 11, 12:53 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines

Diff 173530

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...