Or, something along the lines of:

size_t res __maybe_unused;
res = iov_to_buf(...);
assert (res == VTSCSI_IN_HEADER_LEN(q->vsq_sc);

In D55803#1288531, @emaste wrote:

Or, something along the lines of:

size_t res __maybe_unused;
res = iov_to_buf(...);
assert (res == VTSCSI_IN_HEADER_LEN(q->vsq_sc);

There doesn't seem to be a general definition of __maybe_unused in FreeBSD, or I'm just too dense to find it. Some externals sources like ZFS seem to have it, though.

Perhaps I could use maybe_unused, but that's a C23 feature.

There doesn't seem to be a general definition of __maybe_unused in FreeBSD

Ah, yes. We seem two have three copies of the #define in our tree, two under sys/, but it's not generally available. We could perhaps define it in cdefs.h, but independent of this change.

In D55803#1291246, @emaste wrote:

There doesn't seem to be a general definition of __maybe_unused in FreeBSD

Ah, yes. We seem two have three copies of the #define in our tree, two under sys/, but it's not generally available. We could perhaps define it in cdefs.h, but independent of this change.

Done, please see https://reviews.freebsd.org/D56517

Updated commit message for return to using assert