Page MenuHomeFreeBSD
Differential D53105

tcp: debugging checks of hashing
AbandonedPublic
Actions

Authored by gallatin on Oct 14 2025, 7:47 PM.
Tags
None
Referenced Files
F156448743: D53105.id164181.diff
Wed, May 13, 6:32 PM
Unknown Object (File)
Tue, May 12, 4:09 PM
Unknown Object (File)
Mon, May 11, 9:22 AM
Unknown Object (File)
Sat, May 2, 2:49 PM
Unknown Object (File)
Sat, May 2, 2:49 PM
Unknown Object (File)
Sat, May 2, 2:49 PM
Unknown Object (File)
Wed, Apr 29, 2:29 PM
Unknown Object (File)
Wed, Apr 29, 2:26 PM
View All 54 Files
Subscribers
glebius
imp
kbowling
melifaro
tuexen

Details

Reviewers
None
Group Reviewers
transport
Summary

Not sure if I want to keep this and clean it up, or throw it away

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67789
Build 64672: arc lint + arc unit

Event Timeline

gallatin created this revision.Oct 14 2025, 7:47 PM
Herald added a reviewer: transport. · View Herald TranscriptOct 14 2025, 7:47 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
gallatin requested review of this revision.Oct 14 2025, 7:47 PM
Harbormaster completed remote builds in B67789: Diff 164181.Oct 14 2025, 7:47 PM
kbowling added a subscriber: kbowling.Oct 14 2025, 8:49 PM

I think this would be useful for driver developers, but we'd need to document is suitably so people know to look for it.

tuexen added a subscriber: tuexen.Oct 14 2025, 8:59 PM

I think they are useful.

sys/netinet/tcp_input.c
238

What about using stats counters instead of sysctl variables. netstat could print them.

243

Would it make sense to use bool?

tuexen added a comment.Oct 14 2025, 9:03 PM

Why do we have D53088 and D53105?

gallatin added inline comments.Oct 15 2025, 3:38 PM
sys/netinet/tcp_input.c
238

What about using stats counters instead of sysctl variables. netstat could print them.

Yes, if we're not going to throw this away, then it should use proper stats.

243

Yes, again, having this review show up was a git-arc accident

gallatin mentioned this in D53100: ena: use newly exposed RSS hash key API rather than ad-hoc hashing.Oct 16 2025, 12:56 PM
gallatin mentioned this in D53091: mlx5: use newly exposed RSS hash key API rather than ad-hoc hashing.Oct 17 2025, 7:16 PM
gallatin abandoned this revision.Nov 24 2025, 3:44 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
68 lines

Diff 164181

View Options

sys/netinet/tcp_input.c

Loading...