Page MenuHomeFreeBSD

tcp: debugging checks of hashing
Needs ReviewPublic

Authored by gallatin on Tue, Oct 14, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 1, 5:27 PM
Unknown Object (File)
Sat, Nov 1, 4:21 AM
Unknown Object (File)
Wed, Oct 29, 4:40 AM
Unknown Object (File)
Tue, Oct 28, 8:37 AM
Unknown Object (File)
Sun, Oct 26, 11:38 PM
Unknown Object (File)
Sun, Oct 26, 11:38 PM
Unknown Object (File)
Sun, Oct 26, 11:34 PM
Unknown Object (File)
Thu, Oct 23, 8:54 AM

Details

Reviewers
None
Group Reviewers
transport
Summary

Not sure if I want to keep this and clean it up, or throw it away

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67789
Build 64672: arc lint + arc unit

Event Timeline

I think this would be useful for driver developers, but we'd need to document is suitably so people know to look for it.

I think they are useful.

sys/netinet/tcp_input.c
238

What about using stats counters instead of sysctl variables. netstat could print them.

243

Would it make sense to use bool?

sys/netinet/tcp_input.c
238

What about using stats counters instead of sysctl variables. netstat could print them.

Yes, if we're not going to throw this away, then it should use proper stats.

243

Yes, again, having this review show up was a git-arc accident