ena: use newly exposed RSS hash key API rather than ad-hoc hashing

[akiyano_amazon.com]

Hi,

Thank you for submitting this patch.
Can you please provide a commit message that explains this change.
For example questions that immediately arise:

1. What "newly exposed RSS hash key API" you are talking about (link to the commits that added this API)?
2. Why it is ok to remove the #ifdef RSS?
3. Why do you also remove the #ifdef RSS in ena_datapath.c?
4. How did you test the change?

Thanks!

[gallatin]

In D53100#1213606, @akiyano_amazon.com wrote:

Hi,

Thank you for submitting this patch.
Can you please provide a commit message that explains this change.
For example questions that immediately arise:

1. What "newly exposed RSS hash key API" you are talking about (link to the commits that added this API)?
2. Why it is ok to remove the #ifdef RSS?
3. Why do you also remove the #ifdef RSS in ena_datapath.c?
4. How did you test the change?

Thanks!

Sorry, I wish I was better at reviews of patch series. This is not my favorite review tool.

This is one of many patches, starting with https://reviews.freebsd.org/D53089 and ending with https://reviews.freebsd.org/D53104. The goal is to achieve consistent hashing for TCP ingress/egress by exposing the hashing parts of RSS to drivers, so that all NICs use the same hash key and algo.

Testing was done with netflix traffic on mlx5, ixl and ix using https://reviews.freebsd.org/D53105

Looking at ena_datapath, it looks like I also need to unifdef the check for toeplitz being enabled.

[gallatin]

Update patch to unifdef check for adapter using toeplitz hashing