Page MenuHomeFreeBSD
Differential D52652

iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour
ClosedPublic
Actions

Authored by adrian on Sun, Sep 21, 2:04 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Oct 17, 5:27 AM
Unknown Object (File)
Tue, Oct 14, 11:25 PM
Unknown Object (File)
Tue, Oct 14, 11:25 PM
Unknown Object (File)
Tue, Oct 14, 11:25 PM
Unknown Object (File)
Tue, Oct 14, 11:25 PM
Unknown Object (File)
Tue, Oct 14, 2:38 PM
Unknown Object (File)
Sun, Oct 12, 1:49 AM
Unknown Object (File)
Thu, Oct 2, 4:06 PM
View All 23 Files
Subscribers
imp

Details

Reviewers
kevans
Group Reviewers
wireless
Commits
rG522455887078: iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour
Summary

I received a report on freebsd-wireless@ that traffic stopped working.
It seems that although my AX210 is fine with this change, the AX201/22000
hardware/firmware seems to require it.

There's a bit to set in the TX command to force the FW to set the
sequence control. We only set a few flags, and we don't set that.

So, add the sequence number allocation where encryption is performed.

Locally tested:

  • AX210, STA mode
  • AX201, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67214
Build 64097: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Sep 21, 2:04 AM
Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 21, 2:04 AM
adrian requested review of this revision.Sun, Sep 21, 2:04 AM
Harbormaster completed remote builds in B67214: Diff 162506.Sun, Sep 21, 2:05 AM
adrian added a parent revision: D52649: net80211: document some of the crypto/key functions.Sun, Sep 21, 2:05 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian updated this revision to Diff 162510.Sun, Sep 21, 4:52 AM

comment fixes

Harbormaster completed remote builds in B67218: Diff 162510.Sun, Sep 21, 4:52 AM
adrian added a child revision: D52655: iwx: add some lock assertions in the TX start path.Sun, Sep 21, 4:57 AM
kevans added a reviewer: kevans.Sun, Sep 21, 3:42 PM
kevans accepted this revision.Sun, Sep 21, 5:37 PM

This fixes the AX210 in my frame.work that previously made it through association and DHCP, then stopped passing traffic. Thanks!

This revision is now accepted and ready to land.Sun, Sep 21, 5:37 PM
Closed by commit rG522455887078: iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour (authored by adrian). · Explain WhySun, Sep 21, 5:48 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG522455887078: iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwx/
3 lines

Diff 162506

View Options

sys/dev/iwx/if_iwx.c

Loading...