sys: Make the iommu xref uintptr_t
ClosedPublic
Actions

Authored by andrew on Jan 30 2025, 2:51 PM.

Details

Reviewers

kib
manu

Group Reviewers

arm64

Commits

rG451f0333b707: sys: Make the iommu xref uintptr_t

Summary

On arm64 we use the iommu base address as an xref. This fails when
the address has the lower 32-bits in common with another iommu as
they will share an xref.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jan 30 2025, 2:51 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 30 2025, 2:51 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B62142: Diff 150189.Jan 30 2025, 2:51 PM

andrew requested review of this revision.Jan 30 2025, 2:51 PM

andrew added a parent revision: D48725: arm64/its: Support devices not behind an iommu.

kib added inline comments.Jan 30 2025, 4:19 PM

sys/arm64/iommu/smmu.c
1784	So why is it uintptr_t * and not uint64_t *?

andrew added inline comments.Feb 4 2025, 5:03 PM

sys/arm64/iommu/smmu.c
1784	`pci_id_ofw_iommu.xref` is the wrong type, it should be a `uintptr_t`. The intention is for it to be generic where it may vary on different architectures and different busses. As such I was copying the INTRNG use of using an integer type that can contain a pointer.