Page MenuHomeFreeBSD

pcib: Add a new IVAR returning the Thunderbolt generation of a bridge
AcceptedPublic

Authored by jhb on Tue, Dec 9, 8:32 PM.
Tags
None
Referenced Files
F141074544: D54158.diff
Wed, Dec 31, 1:15 PM
Unknown Object (File)
Sat, Dec 20, 9:10 PM
Unknown Object (File)
Thu, Dec 18, 7:31 AM
Unknown Object (File)
Fri, Dec 12, 8:07 AM
Unknown Object (File)
Fri, Dec 12, 1:27 AM
Unknown Object (File)
Thu, Dec 11, 8:33 PM
Unknown Object (File)
Thu, Dec 11, 3:55 PM
Unknown Object (File)
Wed, Dec 10, 2:59 PM
Subscribers

Details

Reviewers
imp
obiwac
Summary

Use the presence of the new IVAR to determine if a parent pcib device
is a Thunderbolt bridge in tb_pci_probe instead of checking device
IDs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69155
Build 66038: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Tue, Dec 9, 8:32 PM
jhb created this revision.

looks good, though I wonder if there is a point in actually passing down tb_gen, considering I don't think we'll be supporting non-TB_GEN_USB4 in a while (and I was gonna remove the existing tb_pcib_identifiers after D52861)

This revision is now accepted and ready to land.Wed, Dec 10, 12:28 PM

I think we just need some sort of IVAR we can test for and this is just as easy as any other. Can you test this to make sure it works? I have only compile tested it as my only FreeBSD box with TB has the older chipsets that don't work.

In D54158#1237352, @jhb wrote:

I think we just need some sort of IVAR we can test for and this is just as easy as any other. Can you test this to make sure it works? I have only compile tested it as my only FreeBSD box with TB has the older chipsets that don't work.

sorry this is taking a while. I'm looking at this but debugging a panic I'm getting when loading from loader (which for me is required to get the thunderbolt pci bridge to attach - we should probably rename this to something else than tboltX?).

will test as soon as i can