Paths

Table of Contentst

tcp: improve handling of setsockopt
ClosedPublic
Actions

Authored by tuexen on May 18 2024, 10:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 2, 9:53 PM

	Unknown Object (File)
	Sat, Aug 31, 4:22 PM

	Unknown Object (File)
	Sat, Aug 31, 11:47 AM

	Unknown Object (File)
	Thu, Aug 22, 3:12 AM

	Unknown Object (File)
	Thu, Aug 22, 3:12 AM

	Unknown Object (File)
	Aug 9 2024, 2:39 AM

	Unknown Object (File)
	Aug 9 2024, 2:06 AM

	Unknown Object (File)
	Aug 4 2024, 8:49 AM

Subscribers

Details

Reviewers

rrs
rscheff
peter.lei_ieee.org
lstewart
glebius

Group Reviewers

transport

Commits

rGd48fcf99c450: tcp: improve inp locking in setsockopt
rGfe136aecc2a0: tcp: improve inp locking in setsockopt

Summary

Ensure that the inp is not dropped when starting a stack switch. While there, clean-up the code by using INP_WLOCK_RECHECK, which also re-assigns tp.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.May 18 2024, 10:22 AM

Herald added a reviewer: transport. · View Herald TranscriptMay 18 2024, 10:22 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.May 18 2024, 10:22 AM

glebius accepted this revision.May 23 2024, 7:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2024, 8:20 PM

Closed by commit rGfe136aecc2a0: tcp: improve inp locking in setsockopt (authored by tuexen). · Explain Why

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGfe136aecc2a0: tcp: improve inp locking in setsockopt.

tuexen added a commit: rGd48fcf99c450: tcp: improve inp locking in setsockopt.Aug 3 2024, 10:33 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

9 lines

Diff 138712

View Options

tcp: improve handling of setsockoptClosedPublicActions