Page MenuHomeFreeBSD
Differential D43891

acpi: Don't assume a resource is reserved in acpi_delete_resource
ClosedPublic
Actions

Authored by jhb on Feb 14 2024, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 1:23 AM
Unknown Object (File)
Tue, Nov 4, 7:15 PM
Unknown Object (File)
Wed, Oct 29, 12:06 PM
Unknown Object (File)
Tue, Oct 28, 4:02 PM
Unknown Object (File)
Tue, Oct 28, 2:57 PM
Unknown Object (File)
Tue, Oct 28, 12:41 PM
Unknown Object (File)
Sat, Oct 18, 1:30 AM
Unknown Object (File)
Sat, Oct 18, 12:45 AM
View All Files
Subscribers
imp

Details

Reviewers
kevans
andrew
imp
Commits
rG7204a656fcfa: acpi: Don't assume a resource is reserved in acpi_delete_resource
rGcfb8cc9c5fa9: acpi: Don't assume a resource is reserved in acpi_delete_resource
rGe05436d577de: acpi: Don't assume a resource is reserved in acpi_delete_resource
Summary

This fixes a panic if a driver uses bus_set_resource to add a resource
that fails to reserve and then deletes the resource via
bus_delete_resource.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 14 2024, 6:55 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 14 2024, 6:55 PM
jhb requested review of this revision.Feb 14 2024, 6:55 PM
jhb added a parent revision: D43890: pci_host_generic: Include the bridge's device name in rman descriptions.
Harbormaster completed remote builds in B56010: Diff 134327.Feb 14 2024, 6:55 PM
jhb added a child revision: D43892: acpi: Allow drivers to use bus_set_resource for more resources.Feb 14 2024, 6:55 PM
imp accepted this revision.Feb 14 2024, 7:10 PM
This revision is now accepted and ready to land.Feb 14 2024, 7:10 PM
imp added a comment.Feb 14 2024, 7:10 PM

I'm surprised this hasn't bitten sooner

jhb added a comment.Feb 14 2024, 7:30 PM
In D43891#1001335, @imp wrote:

I'm surprised this hasn't bitten sooner

Very few things use bus_delete_resource. I only hit this when I ran into the ram0 problem and my changes to pci_host_generic caused a bridge to fail to probe when it couldn't allocate its window,

Closed by commit rGe05436d577de: acpi: Don't assume a resource is reserved in acpi_delete_resource (authored by jhb). · Explain WhyFeb 14 2024, 10:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGe05436d577de: acpi: Don't assume a resource is reserved in acpi_delete_resource.
jhb added a commit: rGcfb8cc9c5fa9: acpi: Don't assume a resource is reserved in acpi_delete_resource.Apr 8 2024, 7:06 PM
jhb added a commit: rG7204a656fcfa: acpi: Don't assume a resource is reserved in acpi_delete_resource.Apr 8 2024, 8:26 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
3 lines

Diff 134363

View Options

sys/dev/acpica/acpi.c

Loading...