Page MenuHomeFreeBSD

acpi: Don't assume a resource is reserved in acpi_delete_resource
ClosedPublic

Authored by jhb on Feb 14 2024, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 12:34 AM
Unknown Object (File)
Sat, Aug 8, 7:30 PM
Unknown Object (File)
Sat, Aug 8, 2:39 PM
Unknown Object (File)
Thu, Aug 6, 1:19 AM
Unknown Object (File)
Thu, Aug 6, 1:18 AM
Unknown Object (File)
Wed, Jul 29, 2:23 AM
Unknown Object (File)
Jun 26 2026, 7:19 PM
Unknown Object (File)
Jun 25 2026, 7:43 PM
Subscribers

Details

Summary

This fixes a panic if a driver uses bus_set_resource to add a resource
that fails to reserve and then deletes the resource via
bus_delete_resource.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 14 2024, 7:10 PM

I'm surprised this hasn't bitten sooner

In D43891#1001335, @imp wrote:

I'm surprised this hasn't bitten sooner

Very few things use bus_delete_resource. I only hit this when I ran into the ram0 problem and my changes to pci_host_generic caused a bridge to fail to probe when it couldn't allocate its window,