Page MenuHomeFreeBSD

acpi: Use bus_generic_alloc_resource instead of duplicating it
ClosedPublic

Authored by jhb on Jan 31 2024, 7:48 PM.
Tags
None
Referenced Files
F156528319: D43686.id134050.diff
Thu, May 14, 10:51 AM
F156528288: D43686.id134050.diff
Thu, May 14, 10:50 AM
Unknown Object (File)
Wed, May 13, 7:41 AM
Unknown Object (File)
Tue, May 12, 2:42 PM
Unknown Object (File)
Tue, May 12, 2:37 PM
Unknown Object (File)
Wed, Apr 29, 9:35 AM
Unknown Object (File)
Wed, Apr 29, 9:30 AM
Unknown Object (File)
Tue, Apr 28, 7:27 PM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jan 31 2024, 7:48 PM
jhb created this revision.

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

This revision is now accepted and ready to land.Feb 8 2024, 11:20 PM
In D43686#998982, @imp wrote:

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

Hah, ok. I can add something like "No functional change, but it is cleaner to use the existing generic wrappers rather than KOBJ methods directly."

In D43686#999008, @jhb wrote:
In D43686#998982, @imp wrote:

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

Hah, ok. I can add something like "No functional change, but it is cleaner to use the existing generic wrappers rather than KOBJ methods directly."

Perfect. It's such a basic change in some ways, so it's hard to know if it's a cleanliness thing, or some subtle difference between wrappers and KOBJ_SHOUTING_VERSIONS.