Page MenuHomeFreeBSD

acpi: Use bus_generic_alloc_resource instead of duplicating it
ClosedPublic

Authored by jhb on Jan 31 2024, 7:48 PM.
Tags
None
Referenced Files
F146398377: D43686.diff
Mon, Mar 2, 9:29 AM
Unknown Object (File)
Sun, Mar 1, 6:12 AM
Unknown Object (File)
Sat, Feb 28, 10:32 AM
Unknown Object (File)
Tue, Feb 24, 11:03 PM
Unknown Object (File)
Mon, Feb 23, 10:25 PM
Unknown Object (File)
Wed, Feb 11, 5:27 PM
Unknown Object (File)
Sat, Feb 7, 11:18 PM
Unknown Object (File)
Jan 30 2026, 6:07 PM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jan 31 2024, 7:48 PM
jhb created this revision.

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

This revision is now accepted and ready to land.Feb 8 2024, 11:20 PM
In D43686#998982, @imp wrote:

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

Hah, ok. I can add something like "No functional change, but it is cleaner to use the existing generic wrappers rather than KOBJ methods directly."

In D43686#999008, @jhb wrote:
In D43686#998982, @imp wrote:

This is the sort of commit that needs a one to three line 'why?' because I can guarantee in a year or five when someone looks at this they will ask themselves that.

Hah, ok. I can add something like "No functional change, but it is cleaner to use the existing generic wrappers rather than KOBJ methods directly."

Perfect. It's such a basic change in some ways, so it's hard to know if it's a cleanliness thing, or some subtle difference between wrappers and KOBJ_SHOUTING_VERSIONS.