Some implementations copy data to userspace, an operation which can in
principle fail. In preparation for adding a __result_use_check
annotation to copyin() and related functions, let implementations of
cpu_set_upcall() return an error, and check for errors when copying data
to user memory.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Might be a worth idea would be to split UVA accessing parts into a separate upcall. Not least because it is really x86-specific.
Comment Actions
I don't have much of an opinion on this. Note that the powerpc64 implementation needs to be able to return errors from copyin(). I fixed it in a separate diff.