Page MenuHomeFreeBSD

busdma: tidy bus_dma_run_filter() functions
ClosedPublic

Authored by mhorne on Dec 4 2023, 3:20 PM.
Tags
None
Referenced Files
F167506533: D42896.id131093.diff
Sat, Aug 22, 9:03 AM
Unknown Object (File)
Fri, Aug 14, 7:54 PM
Unknown Object (File)
Thu, Aug 13, 12:38 AM
Unknown Object (File)
Wed, Aug 12, 4:22 PM
Unknown Object (File)
Mon, Aug 10, 12:07 PM
Unknown Object (File)
Sat, Aug 8, 5:36 AM
Unknown Object (File)
Wed, Aug 5, 9:11 AM
Unknown Object (File)
Wed, Aug 5, 7:25 AM

Details

Summary

After removing filter functionality, the naming doesn't clearly
represent what the function does, so try to address this. Include some
code clarity and style improvements.

Create a common version in subr_busdma_bounce.c, used by most
implementations. powerpc still needs its own version of the function,
due to its dmat->iommu == NULL check.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/arm64/arm64/busdma_bounce.c
228–234

Here it seems like the logic is changed, but it is not. In practice BF_COULD_BOUNCE is set whenever the tag's alignment requirement is > 1.

This revision is now accepted and ready to land.Dec 6 2023, 4:13 PM
This revision was automatically updated to reflect the committed changes.