Page MenuHomeFreeBSD
Differential D42895

busdma: remove parent tag tracking
ClosedPublic
Actions

Authored by mhorne on Dec 4 2023, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 3:28 AM
Unknown Object (File)
Sat, Apr 27, 2:57 AM
Unknown Object (File)
Mar 28 2024, 12:55 AM
Unknown Object (File)
Mar 27 2024, 12:06 AM
Unknown Object (File)
Mar 26 2024, 5:15 PM
Unknown Object (File)
Mar 21 2024, 3:44 AM
Unknown Object (File)
Mar 13 2024, 1:26 AM
Unknown Object (File)
Feb 17 2024, 5:29 AM
View All 15 Files
Subscribers
emaste
jhibbits
riscv

Details

Reviewers
jhb
imp
andrew
manu
Group Reviewers
arm64
PowerPC
Commits
rG1228b93b410a: busdma: remove parent tag tracking
Summary

Without filter functions, we do not need to keep track of tag ancestry.
All inheritance of the parent tag's parameters occurs when creating the
new child tag.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Dec 4 2023, 3:20 PM
Herald added a reviewer: andrew. · View Herald TranscriptDec 4 2023, 3:20 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, jhibbits, emaste. · View Herald Transcript
mhorne requested review of this revision.Dec 4 2023, 3:20 PM
mhorne added a parent revision: D42894: busdma: kill filter functionality internally.
mhorne added a child revision: D42896: busdma: tidy bus_dma_run_filter() functions.
Harbormaster completed remote builds in B54767: Diff 130988.Dec 4 2023, 3:20 PM
jhb accepted this revision.Dec 5 2023, 7:07 PM

(You can build kernel configs with options KTR to test the dmat_copy fixes. I'm not sure if NOTES includes it such that tinderbox covers KTR or not.)

sys/arm/arm/busdma_machdep.c
518

This still uses dmat_copy here. I think you can change it to just use dmat now.

(Also in the other N copies of this)

This revision is now accepted and ready to land.Dec 5 2023, 7:07 PM
Closed by commit rG1228b93b410a: busdma: remove parent tag tracking (authored by mhorne). · Explain WhyDec 6 2023, 11:22 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG1228b93b410a: busdma: remove parent tag tracking.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
60 lines
arm64/
arm64/
33 lines
17 lines
include/
2 lines
dev/
iommu/
23 lines
powerpc/
powerpc/
50 lines
riscv/
include/
2 lines
riscv/
29 lines
19 lines
x86/
include/
2 lines
iommu/
1 line
x86/
29 lines
22 lines

Diff 131092

View Options

sys/arm/arm/busdma_machdep.c

Loading...
View Options

sys/arm64/arm64/busdma_bounce.c

Loading...
View Options

sys/arm64/arm64/busdma_machdep.c

Loading...
View Options

sys/arm64/include/bus_dma_impl.h

Loading...
View Options

sys/dev/iommu/busdma_iommu.c

Loading...
View Options

sys/powerpc/powerpc/busdma_machdep.c

Loading...
View Options

sys/riscv/include/bus_dma_impl.h

Loading...
View Options

sys/riscv/riscv/busdma_bounce.c

Loading...
View Options

sys/riscv/riscv/busdma_machdep.c

Loading...
View Options

sys/x86/include/busdma_impl.h

Loading...
View Options

sys/x86/iommu/intel_ctx.c

Loading...
View Options

sys/x86/x86/busdma_bounce.c

Loading...
View Options

sys/x86/x86/busdma_machdep.c

Loading...