Makefile.inc1: Replace obsolete comment NO_CLEAN by WITHOUT_CLEAN
Needs ReviewPublic
Actions

Authored by enweiwu on Dec 3 2022, 11:57 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Oct 16, 7:44 PM

	Unknown Object (File)
	Wed, Oct 8, 1:01 AM

	Unknown Object (File)
	Sat, Oct 4, 4:31 PM

	Unknown Object (File)
	Thu, Sep 25, 2:13 AM

	Unknown Object (File)
	Sep 15 2025, 6:07 AM

	Unknown Object (File)
	Sep 1 2025, 6:12 AM

	Unknown Object (File)
	Aug 26 2025, 2:18 PM

	Unknown Object (File)
	Aug 26 2025, 2:00 PM

Subscribers

Details

Reviewers

lwhsu

Summary

CLEAN is an option in src.opts.mk, so use WITHOUT_CLEAN instead of NO_CLEAN comply with option framework.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

enweiwu created this revision.Dec 3 2022, 11:57 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptDec 3 2022, 11:57 AM

enweiwu requested review of this revision.Dec 3 2022, 11:57 AM

What about the other NO_ options there. Should they also be WITHOUT_ ? Thinking about style.

Not related to this patch, but I've for long wanted that "make help" will output all of this text, instead of hiding it inside the Makefile.inc1 ....

Revision Contents
Changeset List

Path

Size

Makefile.inc1

2 lines

Diff 113791

View Options

Makefile.inc1: Replace obsolete comment NO_CLEAN by WITHOUT_CLEANNeeds ReviewPublicActions