Page MenuHomeFreeBSD

bhyve: avoid uninitialized variable
ClosedPublic

Authored by c.koehne_beckhoff.com on Mar 28 2022, 9:03 AM.

Details

Summary

It was introduced by D33129.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reported-by: Andy Fiddaman <andy@omniosce.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Mar 28 2022, 1:40 PM
rew added inline comments.
usr.sbin/bhyve/pci_emul.c
830

would it make sense to assign addr = 0 when baseptr is NULL? instead of handling it in the case blocks

This revision now requires review to proceed.Apr 1 2022, 5:14 AM
c.koehne_beckhoff.com added inline comments.
usr.sbin/bhyve/pci_emul.c
830

Good idea, I've changed it.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 9:20 AM
This revision was automatically updated to reflect the committed changes.