Page MenuHomeFreeBSD
Differential D34688

bhyve: avoid uninitialized variable
ClosedPublic
Actions

Authored by corvink on Mar 28 2022, 9:03 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Sep 6, 9:46 AM
Unknown Object (File)
Sun, Sep 6, 2:38 AM
Unknown Object (File)
Sat, Sep 5, 10:50 AM
Unknown Object (File)
Sat, Sep 5, 8:34 AM
Unknown Object (File)
Sat, Sep 5, 3:04 AM
Unknown Object (File)
Fri, Sep 4, 11:57 PM
Unknown Object (File)
Fri, Sep 4, 8:52 PM
Unknown Object (File)
Fri, Sep 4, 11:42 AM
View All Files
Subscribers
andy_omniosce.org
bcran
cem
imp
rew
rgrimes

Details

Reviewers
markj
jhb
Group Reviewers
bhyve
Commits
rG8c119b3b711d: bhyve: avoid uninitialized variable
rG8ac8adda8dba: bhyve: avoid uninitialized variable
Summary

It was introduced by D33129.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reported-by: Andy Fiddaman <andy@omniosce.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.Mar 28 2022, 9:03 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 28 2022, 9:03 AM
corvink requested review of this revision.Mar 28 2022, 9:03 AM
corvink mentioned this in D33129: bhyve: add ROM emulation.Mar 28 2022, 9:09 AM
markj accepted this revision as: markj.Mar 28 2022, 1:40 PM
This revision is now accepted and ready to land.Mar 28 2022, 1:40 PM
rew added a subscriber: rew.Mar 31 2022, 8:25 PM
rew added inline comments.
usr.sbin/bhyve/pci_emul.c
830

would it make sense to assign addr = 0 when baseptr is NULL? instead of handling it in the case blocks

corvink updated this revision to Diff 104443.Apr 1 2022, 5:14 AM
  • don't set addr = 0 in case block
This revision now requires review to proceed.Apr 1 2022, 5:14 AM
corvink marked an inline comment as done.Apr 1 2022, 5:14 AM
corvink added inline comments.
usr.sbin/bhyve/pci_emul.c
830

Good idea, I've changed it.

corvink marked an inline comment as done.Apr 1 2022, 5:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 9:20 AM
Closed by commit rG8ac8adda8dba: bhyve: avoid uninitialized variable (authored by corvink, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG8ac8adda8dba: bhyve: avoid uninitialized variable.
manu added a commit: rG8c119b3b711d: bhyve: avoid uninitialized variable.May 16 2022, 3:27 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 104450

View Options

usr.sbin/bhyve/pci_emul.c

Loading...