Page MenuHomeFreeBSD

bhyve: avoid uninitialized variable
ClosedPublic

Authored by corvink on Mar 28 2022, 9:03 AM.
Tags
Referenced Files
Unknown Object (File)
Jan 30 2024, 1:10 AM
Unknown Object (File)
Jan 30 2024, 1:10 AM
Unknown Object (File)
Jan 30 2024, 1:10 AM
Unknown Object (File)
Jan 30 2024, 1:10 AM
Unknown Object (File)
Jan 28 2024, 11:55 AM
Unknown Object (File)
Dec 23 2023, 1:54 AM
Unknown Object (File)
Dec 11 2023, 4:12 AM
Unknown Object (File)
Nov 28 2023, 10:12 PM

Details

Summary

It was introduced by D33129.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reported-by: Andy Fiddaman <andy@omniosce.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Mar 28 2022, 1:40 PM
rew added inline comments.
usr.sbin/bhyve/pci_emul.c
818

would it make sense to assign addr = 0 when baseptr is NULL? instead of handling it in the case blocks

  • don't set addr = 0 in case block
This revision now requires review to proceed.Apr 1 2022, 5:14 AM
corvink added inline comments.
usr.sbin/bhyve/pci_emul.c
818

Good idea, I've changed it.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 9:20 AM
Closed by commit rG8ac8adda8dba: bhyve: avoid uninitialized variable (authored by corvink, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.