Update legacy sysctls
ClosedPublic
Actions

Authored by jlduran on Mar 18 2022, 7:22 AM.

Details

Reviewers

emaste

Group Reviewers

Contributor Reviews (src)

Commits

rG07a3c93bc51e: tools: Update sysctl to its new name
rG14e02220e415: nanobsd: rescue: Update legacy sysctls
rGd2c80ed5c420: tools: Update sysctl to its new name
rG20103d288e80: nanobsd: rescue: Update legacy sysctls
rG68e136b5d684: tools: Update sysctl to its new name
rGdd9f56faa9a6: nanobsd: rescue: Update legacy sysctls
rG84333aada464: tools: Update sysctl to its new name
rG93ee9bb42461: nanobsd: rescue: Update legacy sysctls

Summary

Update references to the new sysctls:

kern.ipc.somaxconn       -> kern.ipc.soacceptqueue
vfs.zfs.arc_max          -> vfs.zfs.arc.max
vfs.zfs.arc_min          -> vfs.zfs.arc.min
vfs.zfs.min_auto_ashift  -> vfs.zfs.vdev.min_auto_ashift
vfs.zfs.prefetch_disable -> vfs.zfs.prefetch.disable
vfs.zfs.zil_disable      -> vfs.zfs.zil.replay_disable

There may be others, but this is a good start.

I fear this change may be too cross-cutting, feel free to break it into several digestible commits if necessary. Nevertheless, no functional changes are intended.

NOTE: Do not MFC to stable/12.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Mar 18 2022, 7:22 AM

Herald added subscribers: delphij, imp. · View Herald TranscriptMar 18 2022, 7:22 AM

jlduran requested review of this revision.Mar 18 2022, 7:22 AM

jlduran added inline comments.Mar 18 2022, 7:50 AM

tools/tools/nanobsd/rescue/Files/root/ZFS_Create.txt
30	The ARC values should be unsigned long (tangential to the change).

emaste added subscribers: mm, allanjude, emaste.Mar 18 2022, 3:23 PM

emaste added inline comments.Oct 11 2022, 4:36 PM

release/tools/gce.conf

89 ↗

(On Diff #103979)

commit 2bdf61ca29d075559a8531962ec4e5f09d1105ed
Author: Andre Oppermann <andre@FreeBSD.org>
Date:   Sat Oct 20 12:53:14 2012 +0000

    Hide the unfortunate named sysctl kern.ipc.somaxconn from sysctl -a
    output and replace it with a new visible sysctl kern.ipc.acceptqueue
    of the same functionality.  It specifies the maximum length of the
    accept queue on a listen socket.
    
    The old kern.ipc.somaxconn remains available for reading and writing
    for compatibility reasons so that existing programs, scripts and
    configurations continue to work.  There no plans to ever remove the
    orginal and now hidden kern.ipc.somaxconn.

This one can be MFC'd to 12

emaste added inline comments.Oct 11 2022, 4:50 PM

release/tools/gce.conf
89 ↗	(On Diff #103979)	This part pushed to main in 9871ae6aa91f, please update this diff at your convenience. (Also, when generating the diff to upload to Phabricator please use `-U 999999` to get full context.)

jlduran added inline comments.Oct 11 2022, 4:50 PM

release/tools/gce.conf
89 ↗	(On Diff #103979)	Great! It is probably better if the changes land individually.
usr.sbin/bsdinstall/scripts/zfsboot
73 ↗	(On Diff #103979)	Worth following up on bug #266374