No functional changes intended
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 41791 Build 38680: arc lint + arc unit
Event Timeline
sys/compat/linuxkpi/common/include/linux/scatterlist.h | ||
---|---|---|
569 | Do you need to use kmap/kunmap here or can you not just pin the entire loop and us sf_* directly as done above? | |
sys/compat/linuxkpi/common/src/linux_page.c | ||
73 | Is this PMAP_HAS_DMAP now? | |
433 | Probably %s: func better here now or rather remove this entirely as we don't have a LINUX_VERBOSE_DEBUG? |
Use PMAP_HAS_DMAP instead of LP64
Optimize sg_pcopy_to_buffer() for !PMAP_HAS_DMAP case
Move kmap/kunmap implementation in to header file
Drop debugging printf
sys/compat/linuxkpi/common/include/linux/scatterlist.h | ||
---|---|---|
569 |
loop is rewritten to use pin/unpin and sf_* directly | |
sys/compat/linuxkpi/common/src/linux_page.c | ||
433 |
debugging stuff removed |
sys/compat/linuxkpi/common/include/linux/scatterlist.h | ||
---|---|---|
567 | min() will truncate parameters to unsigned int. I guess it should be ulmin(). | |
sys/compat/linuxkpi/common/src/linux_page.c | ||
360 | We always start at pindex 0, so holebegin is ignored. I understand that this may provide the desired semantics (or is it a bug?) but it looks wrong and deserves a comment IMHO. | |
369 | Which vm_object_reference() call does this pair with? |
sys/compat/linuxkpi/common/src/linux_page.c | ||
---|---|---|
369 | It lies in linux_file_mmap_single() in sys/compat/linuxkpi/common/src/linux_compat.c (through cdev_pager_allocate() call). This routine is destructor for it. |
sys/compat/linuxkpi/common/include/linux/scatterlist.h | ||
---|---|---|
567 | There is also the MIN() macro and min_t(). |